tests: Rewrite the test harness to be more robust

While at it, add test SC vectors from SIA and NIST. Also rolled out some
custom test cases to excecise the remaining=0 and remaining!=0 code
paths in the encryption sequences. These will come in handy for the next
change to osdp_compute_mac to drop the 256 byte stack buffer.

Signed-off-by: Siddharth Chandrasekaran <sidcha.dev@gmail.com>

Author: sidcha

.github/workflows/build-ci.yml

@@ -41,6 +41,8 @@ jobs:
         ./configure.sh
     - name: make
       run: make V=1
+    - name: make check
+      run: make V=1 check
 
   DocBuild:
     runs-on: ubuntu-latest
@@ -67,9 +69,7 @@ jobs:
     - name: Configure
       run: cmake -DCMAKE_BUILD_TYPE=Debug .
     - name: Run unit-tests
-      run: cmake --build . --parallel 7 --target check-ut
-    - name: Run pytest
-      run: tests/pytest/run.sh
+      run: cmake --build . --parallel 7 --target check
 
   CheckPatch:
     runs-on: ubuntu-latest

.github/workflows/cross-plaform-build.yml

@@ -26,7 +26,7 @@ jobs:
     - name: Build
       run: cmake --build build --parallel 8
     - name: Run unit-tests
-      run: cmake --build build --parallel 8 --target check-ut
+      run: cmake --build build --parallel 8 --target check
     - name: Pack built binaries
       run: cmake --build build --target package
     - name: Upload artifacts

configure.sh

@@ -184,6 +184,8 @@ TEST_SOURCES+=" tests/unit-tests/test-cp-fsm.c"
 TEST_SOURCES+=" tests/unit-tests/test-file.c"
 TEST_SOURCES+=" tests/unit-tests/test-async-fuzz.c"
 TEST_SOURCES+=" tests/unit-tests/test-hotplug.c"
+TEST_SOURCES+=" tests/unit-tests/test-sc.c"
+TEST_SOURCES+=" tests/unit-tests/test-sc-sia-vectors.c"
 TEST_SOURCES+=" ${LIBOSDP_SOURCES} ${UTILS_SOURCES}"
 
 if [[ ! -z "${LIB_ONLY}" ]]; then

src/osdp_sc.c

@@ -245,3 +245,12 @@ void osdp_sc_teardown(struct osdp_pd *pd)
 	ARG_UNUSED(pd);
 	osdp_crypt_teardown();
 }
+
+#ifdef UNIT_TESTING
+int (*test_osdp_compute_mac)(struct osdp_pd *pd, int is_cmd,
+			     const uint8_t *data, int len) = osdp_compute_mac;
+int (*test_osdp_encrypt_data)(struct osdp_pd *pd, int is_cmd,
+			      uint8_t *data, int length) = osdp_encrypt_data;
+int (*test_osdp_decrypt_data)(struct osdp_pd *pd, int is_cmd,
+			      uint8_t *data, int length) = osdp_decrypt_data;
+#endif /* UNIT_TESTING */

tests/unit-tests/CMakeLists.txt

@@ -25,6 +25,8 @@ list(APPEND OSDP_UNIT_TEST_SRC
 	test-events.c
 	test-hotplug.c
 	test-async-fuzz.c
+	test-sc.c
+	test-sc-sia-vectors.c
 )
 
 add_executable(${OSDP_UNIT_TEST} EXCLUDE_FROM_ALL ${OSDP_UNIT_TEST_SRC})
@@ -45,8 +47,13 @@ include_directories(
 	${PROJECT_SOURCE_DIR}/utils/include
 )
 
-add_custom_target(check-ut
+add_custom_target(check
 	COMMAND ${CMAKE_BINARY_DIR}/bin/${OSDP_UNIT_TEST}
 	COMMAND rm ${CMAKE_BINARY_DIR}/bin/${OSDP_UNIT_TEST}
 	DEPENDS ${OSDP_UNIT_TEST}
 )
+
+# Backward-compatible alias; prefer `check`.
+add_custom_target(check-ut
+	DEPENDS check
+)