fix conversions for -m32 cpu arch flag#11
Open
gofish wants to merge 1 commit into
Open
Conversation
gofish
commented
May 30, 2018
| } else { | ||
| /* ensure wait-queue occupies the head of the array */ | ||
| memmove(_io_reqs, _io_reqs + i, (size_t)(_nwait - i)); | ||
| memmove(_io_reqs, _io_reqs + i, (size_t)(requestCount)); |
Owner
Author
There was a problem hiding this comment.
The behavior is unchanged here but it may be that the behavior is not ideal. We seem to be dropping all submitted requests when an error other than EBADF or EINVAL occurs for the zeroth file descriptor.
The other possibilities are
- EAGAIN - this shouldn't happen if we are accurately tracking the kernel queue depth in the library
- EFAULT - this shouldn't happen if we are initializing structures correctly in the library
- EINVAL - this shouldn't happen if the context and requests were properly initialized
- ENOSYS - this shouldn't happen if there is support for
io_submiton the system
Some of these should probably abort(3) the program, and the rest should probably just return -1 and set errno.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5