Skip to content

Commit 69532a5

Browse files
committed
fix richpresence parameter name
1 parent f5d47b0 commit 69532a5

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

src/galaxy/api/plugin.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -971,11 +971,11 @@ async def get_os_compatibility(self, game_id: str, context: Any) -> Optional[OSC
971971
def os_compatibility_import_complete(self) -> None:
972972
"""Override this method to handle operations after OS compatibility import is finished (like updating cache)."""
973973

974-
async def _start_user_presence_import(self, user_ids: List[str]) -> None:
974+
async def _start_user_presence_import(self, user_id_list: List[str]) -> None:
975975
if self._user_presence_import_in_progress:
976976
raise ImportInProgress()
977977

978-
context = await self.prepare_user_presence_context(user_ids)
978+
context = await self.prepare_user_presence_context(user_id_list)
979979

980980
async def import_user_presence(user_id, context_) -> None:
981981
try:
@@ -986,30 +986,30 @@ async def import_user_presence(user_id, context_) -> None:
986986
logger.exception("Unexpected exception raised in import_user_presence")
987987
self._user_presence_import_failure(user_id, UnknownError())
988988

989-
async def import_user_presence_set(user_ids_, context_) -> None:
989+
async def import_user_presence_set(user_id_list_, context_) -> None:
990990
try:
991991
await asyncio.gather(*[
992992
import_user_presence(user_id, context_)
993-
for user_id in user_ids_
993+
for user_id in user_id_list_
994994
])
995995
finally:
996996
self._user_presence_import_finished()
997997
self._user_presence_import_in_progress = False
998998
self.user_presence_import_complete()
999999

10001000
self._external_task_manager.create_task(
1001-
import_user_presence_set(user_ids, context),
1001+
import_user_presence_set(user_id_list, context),
10021002
"user presence import",
10031003
handle_exceptions=False
10041004
)
10051005
self._user_presence_import_in_progress = True
10061006

1007-
async def prepare_user_presence_context(self, user_ids: List[str]) -> Any:
1007+
async def prepare_user_presence_context(self, user_id_list: List[str]) -> Any:
10081008
"""Override this method to prepare context for get_user_presence.
10091009
This allows for optimizations like batch requests to platform API.
10101010
Default implementation returns None.
10111011
1012-
:param user_ids: the ids of the users for whom presence information is imported
1012+
:param user_id_list: the ids of the users for whom presence information is imported
10131013
:return: context
10141014
"""
10151015
return None

tests/test_user_presence.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
@pytest.mark.asyncio
1313
async def test_get_user_presence_success(plugin, read, write):
1414
context = "abc"
15-
user_ids = ["666", "13", "42", "69", "22"]
15+
user_id_list = ["666", "13", "42", "69", "22"]
1616
plugin.prepare_user_presence_context.return_value = async_return_value(context)
1717
request = {
1818
"jsonrpc": "2.0",
1919
"id": "11",
2020
"method": "start_user_presence_import",
21-
"params": {"user_ids": user_ids}
21+
"params": {"user_id_list": user_id_list}
2222
}
2323
read.side_effect = [async_return_value(create_message(request)), async_return_value(b"", 10)]
2424
plugin.get_user_presence.side_effect = [
@@ -60,7 +60,7 @@ async def test_get_user_presence_success(plugin, read, write):
6060
]
6161
await plugin.run()
6262
plugin.get_user_presence.assert_has_calls([
63-
call(user_id, context) for user_id in user_ids
63+
call(user_id, context) for user_id in user_id_list
6464
])
6565
plugin.user_presence_import_complete.assert_called_once_with()
6666

@@ -151,7 +151,7 @@ async def test_get_user_presence_error(exception, code, message, plugin, read, w
151151
"jsonrpc": "2.0",
152152
"id": request_id,
153153
"method": "start_user_presence_import",
154-
"params": {"user_ids": [user_id]}
154+
"params": {"user_id_list": [user_id]}
155155
}
156156
read.side_effect = [async_return_value(create_message(request)), async_return_value(b"", 10)]
157157
plugin.get_user_presence.side_effect = exception
@@ -192,7 +192,7 @@ async def test_prepare_get_user_presence_context_error(plugin, read, write):
192192
"jsonrpc": "2.0",
193193
"id": request_id,
194194
"method": "start_user_presence_import",
195-
"params": {"user_ids": ["6"]}
195+
"params": {"user_id_list": ["6"]}
196196
}
197197
read.side_effect = [async_return_value(create_message(request)), async_return_value(b"", 10)]
198198
await plugin.run()
@@ -218,15 +218,15 @@ async def test_import_already_in_progress_error(plugin, read, write):
218218
"id": "3",
219219
"method": "start_user_presence_import",
220220
"params": {
221-
"user_ids": ["42"]
221+
"user_id_list": ["42"]
222222
}
223223
},
224224
{
225225
"jsonrpc": "2.0",
226226
"id": "4",
227227
"method": "start_user_presence_import",
228228
"params": {
229-
"user_ids": ["666"]
229+
"user_id_list": ["666"]
230230
}
231231
}
232232
]

0 commit comments

Comments
 (0)