Skip to content

Commit cd452b8

Browse files
author
unknown
committed
include subscription_name in partial finished notification
1 parent 19c9f14 commit cd452b8

2 files changed

Lines changed: 20 additions & 6 deletions

File tree

src/galaxy/api/plugin.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ async def _import_element(self, id_, context_):
129129
logger.exception("Unexpected exception raised in %s importer", self._name)
130130
self._notification_failure(id_, UnknownError())
131131
finally:
132-
self._notification_partial_finished()
132+
self._notification_partial_finished(id_)
133133

134134

135135
class Plugin:
@@ -722,8 +722,13 @@ def _subscription_games_import_failure(self, subscription_name: str, error: Appl
722722
}
723723
)
724724

725-
def _subscriptions_games_partial_import_finished(self) -> None:
726-
self._connection.send_notification("subscription_games_partial_import_finished", None)
725+
def _subscriptions_games_partial_import_finished(self, subscription_name: str) -> None:
726+
self._connection.send_notification(
727+
"subscription_games_partial_import_finished",
728+
{
729+
"subscription_name": subscription_name
730+
}
731+
)
727732

728733
def _subscription_games_import_finished(self) -> None:
729734
self._connection.send_notification("subscription_games_import_finished", None)

tests/test_subscriptions.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,10 @@ async def sub_games():
143143
{
144144
'jsonrpc': '2.0',
145145
'method':
146-
'subscription_games_partial_import_finished', 'params': None
146+
'subscription_games_partial_import_finished',
147+
'params': {
148+
"subscription_name": "sub_a"
149+
}
147150
},
148151
{
149152
"jsonrpc": "2.0",
@@ -191,7 +194,10 @@ async def sub_games():
191194
{
192195
'jsonrpc': '2.0',
193196
'method':
194-
'subscription_games_partial_import_finished', 'params': None
197+
'subscription_games_partial_import_finished',
198+
'params': {
199+
"subscription_name": "sub_a"
200+
}
195201
},
196202
{
197203
"jsonrpc": "2.0",
@@ -242,7 +248,10 @@ async def test_get_subscription_games_error(exception, code, message, plugin, re
242248
{
243249
'jsonrpc': '2.0',
244250
'method':
245-
'subscription_games_partial_import_finished', 'params': None
251+
'subscription_games_partial_import_finished',
252+
'params': {
253+
"subscription_name": "sub_a"
254+
}
246255
},
247256
{
248257
"jsonrpc": "2.0",

0 commit comments

Comments
 (0)