Skip to content

Commit 59ca266

Browse files
author
gdgate
authored
Merge pull request #1042 from helobinvn/github-action
Use codecov for checking coverage step instead of coveralls Reviewed-by: Libor Ryšavý https://github.com/liry
2 parents e831ae9 + cf09fb7 commit 59ca266

3 files changed

Lines changed: 9 additions & 30 deletions

File tree

.github/workflows/build.yml

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,12 @@ jobs:
2222
path: ~/.m2
2323
key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
2424
restore-keys: ${{ runner.os }}-m2
25-
- name: Set branch name and PR number
26-
id: refs
27-
env:
28-
BRANCH_NAME_OR_REF: ${{ github.head_ref || github.ref }}
25+
- name: Run build steps and generate coverage report
2926
run: |
30-
echo "::set-output name=branch_name::${BRANCH_NAME_OR_REF#refs/heads/}"
31-
echo "::set-output name=pr_number::$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH")"
32-
- name: Run build steps and check coverage
33-
env:
34-
CI_NAME: Github
35-
CI_BUILD_NUMBER: ${{ github.run_id }}
36-
CI_BUILD_URL: https://github.com/${{ github.repository }}/commit/${{ github.event.after }}/checks
37-
CI_BRANCH: ${{ steps.refs.outputs.branch_name }}
38-
CI_PULL_REQUEST: ${{ steps.refs.outputs.pr_number }}
39-
run: |
40-
mvn verify javadoc:javadoc coveralls:report -Pcoverage -DrepoToken=${{ secrets.COVERALLS_REPO_TOKEN }} -B -V
27+
mvn verify javadoc:javadoc jacoco:report -Pcoverage -B -V
28+
- name: Upload coverage report to Codecov
29+
uses: codecov/codecov-action@v1
30+
with:
31+
file: ./**/target/site/jacoco/jacoco.xml
32+
name: codecov
33+
fail_ci_if_error: true

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
[![Release](https://img.shields.io/github/release/gooddata/gooddata-java.svg)](https://github.com/gooddata/gooddata-java/releases)
77
[![Stability: Active](https://masterminds.github.io/stability/active.svg)](https://masterminds.github.io/stability/active.html)
88
[![License](https://img.shields.io/badge/license-BSD-blue.svg)](LICENSE.txt)
9-
[![Coverage Status](https://coveralls.io/repos/github/gooddata/gooddata-java/badge.svg?branch=master)](https://coveralls.io/github/gooddata/gooddata-java?branch=master)
9+
[![Coverage Status](https://codecov.io/gh/gooddata/gooddata-java/branch/master/graph/badge.svg)](https://codecov.io/gh/gooddata/gooddata-java/branch/master/graph/badge.svg)
1010

1111
The *GoodData Java SDK* encapsulates the REST API of the **GoodData Platform**.
1212
The first version was implemented during the [All Data Hackathon](http://hackathon.gooddata.com) April 10 - 11 2014.

pom.xml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -178,20 +178,6 @@
178178
<id>coverage</id>
179179
<build>
180180
<plugins>
181-
<plugin>
182-
<groupId>org.eluder.coveralls</groupId>
183-
<artifactId>coveralls-maven-plugin</artifactId>
184-
<version>4.3.0</version>
185-
<!-- ugly hack for java 11 build until https://github.com/trautonen/coveralls-maven-plugin/issues/112 -->
186-
<!-- will be released (coverall-maven-plugin-5.0.0) -->
187-
<dependencies>
188-
<dependency>
189-
<groupId>javax.xml.bind</groupId>
190-
<artifactId>jaxb-api</artifactId>
191-
<version>2.3.1</version>
192-
</dependency>
193-
</dependencies>
194-
</plugin>
195181
<plugin>
196182
<groupId>org.jacoco</groupId>
197183
<artifactId>jacoco-maven-plugin</artifactId>

0 commit comments

Comments
 (0)