Skip to content

Commit 83487bb

Browse files
committed
allow ResultHeaderItem to have empty name
1 parent ec905c3 commit 83487bb

2 files changed

Lines changed: 15 additions & 2 deletions

File tree

src/main/java/com/gooddata/executeafm/result/ResultHeaderItem.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import com.fasterxml.jackson.annotation.JsonTypeInfo;
1010
import com.gooddata.util.GoodDataToStringBuilder;
1111

12-
import static com.gooddata.util.Validate.notEmpty;
12+
import static com.gooddata.util.Validate.notNull;
1313

1414
/**
1515
* Represent header items available in {@link ExecutionResult}
@@ -25,7 +25,7 @@ public abstract class ResultHeaderItem {
2525
private final String name;
2626

2727
protected ResultHeaderItem(final String name) {
28-
this.name = notEmpty(name, "name");
28+
this.name = notNull(name, "name");
2929
}
3030

3131
/**

src/test/groovy/com/gooddata/executeafm/result/ResultHeaderItemTest.groovy

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,17 @@ class ResultHeaderItemTest extends Specification {
2525
typeClass << [AttributeHeaderItem, ResultMeasureHeaderItem, ResultTotalHeaderItem]
2626
type = typeClass.simpleName.uncapitalize()
2727
}
28+
29+
def "should allow empty name"() {
30+
expect:
31+
new ResultHeaderItem('') {}.name == ''
32+
}
33+
34+
def "should not allow null name"() {
35+
when:
36+
new ResultHeaderItem(null) {}
37+
38+
then:
39+
thrown(IllegalArgumentException)
40+
}
2841
}

0 commit comments

Comments
 (0)