Skip to content

Commit e5f7e45

Browse files
committed
Remove useless conditions
1 parent 71c2da0 commit e5f7e45

2 files changed

Lines changed: 3 additions & 12 deletions

File tree

gooddata-java-model/src/main/java/com/gooddata/sdk/model/featureflag/FeatureFlags.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,16 +79,13 @@ private Optional<FeatureFlag> findFlag(final String flagName) {
7979
public boolean equals(final Object o) {
8080
if (this == o) return true;
8181
if (o == null || getClass() != o.getClass()) return false;
82-
8382
final FeatureFlags that = (FeatureFlags) o;
84-
85-
return !(featureFlags != null ? !featureFlags.equals(that.featureFlags) : that.featureFlags != null);
86-
83+
return featureFlags.equals(that.featureFlags);
8784
}
8885

8986
@Override
9087
public int hashCode() {
91-
return featureFlags != null ? featureFlags.hashCode() : 0;
88+
return featureFlags.hashCode();
9289
}
9390

9491
@Override

gooddata-java/src/main/java/com/gooddata/sdk/service/featureflag/FeatureFlagService.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,7 @@ public ProjectFeatureFlag getProjectFeatureFlag(final Project project, final Str
108108
notEmpty(featureFlagName, "featureFlagName");
109109

110110
try {
111-
final ProjectFeatureFlag flag = getProjectFeatureFlag(getProjectFeatureFlagUri(project, featureFlagName));
112-
113-
if (flag == null) {
114-
throw new GoodDataException("empty response from API call");
115-
}
116-
117-
return flag;
111+
return getProjectFeatureFlag(getProjectFeatureFlagUri(project, featureFlagName));
118112
} catch (GoodDataException | RestClientException e) {
119113
throw new GoodDataException("Unable to get project feature flag: " + featureFlagName, e);
120114
}

0 commit comments

Comments
 (0)