Merge pull request #1006 from gooddata/liry2

Mitigate risky code parts

Reviewed-by: Peter Plocháň
             https://github.com/peter-plochan

Author: gdgate

gooddata-java-model/src/main/java/com/gooddata/sdk/model/featureflag/FeatureFlags.java

@@ -79,16 +79,13 @@ private Optional<FeatureFlag> findFlag(final String flagName) {
     public boolean equals(final Object o) {
         if (this == o) return true;
         if (o == null || getClass() != o.getClass()) return false;
-
         final FeatureFlags that = (FeatureFlags) o;
-
-        return !(featureFlags != null ? !featureFlags.equals(that.featureFlags) : that.featureFlags != null);
-
+        return featureFlags.equals(that.featureFlags);
     }
 
     @Override
     public int hashCode() {
-        return featureFlags != null ? featureFlags.hashCode() : 0;
+        return featureFlags.hashCode();
     }
 
     @Override

gooddata-java/src/main/java/com/gooddata/sdk/service/AbstractService.java

@@ -66,6 +66,7 @@ final <R> R poll(final PollHandler<?,R> handler, long timeout, final TimeUnit un
             try {
                 Thread.sleep(settings.getPollSleep());
             } catch (InterruptedException e) {
+                Thread.currentThread().interrupt();
                 throw new GoodDataException("interrupted");
             }
         }

gooddata-java/src/main/java/com/gooddata/sdk/service/connector/ConnectorService.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2004-2019, GoodData(R) Corporation. All rights reserved.
+ * Copyright (C) 2004-2021, GoodData(R) Corporation. All rights reserved.
  * This source code is licensed under the BSD-style license found in the
  * LICENSE.txt file in the root directory of this source tree.
  */
@@ -22,8 +22,8 @@
 import java.io.IOException;
 import java.util.Collection;
 import java.util.Map;
+import java.util.Optional;
 
-import static com.gooddata.sdk.common.util.Validate.isTrue;
 import static com.gooddata.sdk.common.util.Validate.notNull;
 import static com.gooddata.sdk.common.util.Validate.notNullState;
 import static java.lang.String.format;
@@ -267,13 +267,17 @@ public FutureResult<ProcessStatus> getProcessStatus(final IntegrationProcessStat
      * You should use the result of {@link #scheduleZendesk4Reload} to see changes in {@link Reload#getStatus()} and
      * {@link Reload#getProcessId()} or retrieve process URI {@link Reload#getProcessUri()}.
      *
-     * @param reload existing reload.
+     * @param reload existing reload (self link must be present).
      * @return same reload with refreshed properties (status, processId, process URI)
      */
     public Reload getZendesk4Reload(final Reload reload) {
         notNull(reload, "reload");
-        isTrue(reload.getUri().isPresent(), "reload.uri");
-        return getZendesk4ReloadByUri(reload.getUri().get());
+        final Optional<String> reloadUri = reload.getUri();
+        if (reloadUri.isPresent()) {
+            return getZendesk4ReloadByUri(reloadUri.get());
+        } else {
+            throw new IllegalArgumentException("Self link in the Reload must be present!");
+        }
     }
 
     /**

gooddata-java/src/main/java/com/gooddata/sdk/service/dataload/processes/ProcessService.java

@@ -72,7 +72,7 @@ public class ProcessService extends AbstractService {
     public static final UriTemplate PROCESSES_TEMPLATE = new UriTemplate(DataloadProcesses.URI);
     public static final UriTemplate USER_PROCESSES_TEMPLATE = new UriTemplate(DataloadProcesses.USER_PROCESSES_URI);
     private static final MediaType MEDIA_TYPE_ZIP = MediaType.parseMediaType("application/zip");
-    private static final long MAX_MULTIPART_SIZE = 1024 * 1024;
+    private static final long MAX_MULTIPART_SIZE = 1024L * 1024L;
 
     private final AccountService accountService;
     private final DataStoreService dataStoreService;

gooddata-java/src/main/java/com/gooddata/sdk/service/featureflag/FeatureFlagService.java

@@ -108,13 +108,7 @@ public ProjectFeatureFlag getProjectFeatureFlag(final Project project, final Str
         notEmpty(featureFlagName, "featureFlagName");
 
         try {
-            final ProjectFeatureFlag flag = getProjectFeatureFlag(getProjectFeatureFlagUri(project, featureFlagName));
-
-            if (flag == null) {
-                throw new GoodDataException("empty response from API call");
-            }
-
-            return flag;
+            return getProjectFeatureFlag(getProjectFeatureFlagUri(project, featureFlagName));
         } catch (GoodDataException | RestClientException e) {
             throw new GoodDataException("Unable to get project feature flag: " + featureFlagName, e);
         }

gooddata-java/src/test/groovy/com/gooddata/sdk/service/connector/ConnectorServiceTest.groovy

@@ -0,0 +1,38 @@
+/*
+ * Copyright (C) 2004-2021, GoodData(R) Corporation. All rights reserved.
+ * This source code is licensed under the BSD-style license found in the
+ * LICENSE.txt file in the root directory of this source tree.
+ */
+
+package com.gooddata.sdk.service.connector
+
+import com.gooddata.sdk.model.connector.Reload
+import com.gooddata.sdk.service.GoodDataSettings
+import com.gooddata.sdk.service.project.ProjectService
+import org.springframework.web.client.RestTemplate
+import spock.lang.Specification
+import spock.lang.Subject
+
+import static java.util.Collections.emptyMap
+
+class ConnectorServiceTest extends Specification {
+
+    @Subject
+    def service = new ConnectorService(Mock(RestTemplate), Mock(ProjectService), Mock(GoodDataSettings))
+
+    def "getZendesk4Reload should throw when Reload is null"() {
+        when:
+        service.getZendesk4Reload(null)
+
+        then:
+        thrown(IllegalArgumentException)
+    }
+
+    def "getZendesk4Reload should throw when Reload does not contain self URI"() {
+        when:
+        service.getZendesk4Reload(new Reload(emptyMap()))
+
+        then:
+        thrown(IllegalArgumentException)
+    }
+}