Skip to content

Commit 3b801da

Browse files
yuvaltassacopybara-github
authored andcommitted
Explicitly disable tendon range limits and actuator force limits in rodent.xml.
- This model has a bunch of ranges defined (tendon length ranges and actuator force-limit ranges) that are actually inactive due to the associated "limited" property not being set to "true". - A recent change in MuJoCo enabled automatically inferring the "limited" property according to the presence of the associated "range" property, which changed the behaviour of this model and helped us realise the above situation. - This CL explicitly disables tendon ranges limits and actuator force limits while leaving the ranges in place, so the model behaviour remains unchanged. - Since many of the numbers seem to be carefully calibrated, it might be worth investigating in the future whether the limits should actually be activated. PiperOrigin-RevId: 468690429 Change-Id: Icd097a2cafe15e910bca71c5378bddcf3d92665a
1 parent 0281b11 commit 3b801da

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

dm_control/locomotion/walkers/assets/rodent.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
<joint limited="true" solreflimit="0.01 1" solimplimit="0.99 0.9999 0" armature="6e-07" damping="0.001"/>
66
<geom friction="0.7 0.005 0.0001" solref="0.005 1"/>
77
<site group="3" rgba="0 0 1 1"/>
8-
<general ctrllimited="true" ctrlrange="-1 1" gainprm="0.01"/>
8+
<general ctrllimited="true" ctrlrange="-1 1" forcelimited="false" gainprm="0.01"/>
9+
<tendon limited="false"/>
910
<default class="bone">
1011
<geom contype="0" conaffinity="0" group="0" rgba="0.5 0.5 0.5 1" density="1100.0"/>
1112
</default>

0 commit comments

Comments
 (0)