Skip to content

Commit 8e16174

Browse files
nimrod-gileadicopybara-github
authored andcommitted
Add a comment about incorrect initialization of orientations in free joints.
PiperOrigin-RevId: 447716942 Change-Id: Iefac64633c213e1e3864a3b9c499d1349fddb2f0
1 parent bf636b4 commit 8e16174

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

dm_control/suite/utils/randomizers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ def randomize_limited_and_rotational_joints(physics, random=None):
8181
qpos[joint_name] = quat
8282

8383
elif joint_type == free:
84+
# this should be random.randn, but changing it now could significantly
85+
# affect benchmark results.
8486
quat = random.rand(4)
8587
quat /= np.linalg.norm(quat)
8688
qpos[joint_name][3:] = quat

0 commit comments

Comments
 (0)