[BUG]Heap-use-after-free in benchmark `RunSpecifiedBenchmarks

[eglonnnn]

A clear and concise description of what the bug is.

A heap-use-after-free vulnerability in google/benchmark 1.9.4. When RunSpecifiedBenchmarks() is called with a filter that matches no registered benchmark, the static reporter pointer is freed but the cached pointer returned by CreateDefaultDisplayReporter() is not invalidated, causing a use-after-free on the next call.

Impact

• Denial-of-service or potential memory corruption
• Any application using the benchmark library with dynamic filtering is affected

Reproduction

All materials are available in my research repository:
https://github.com/eglonnnn/opensource-fuzz-vulnerability-research/tree/main/Heap-use-after-free%20in%20benchmark%20RunSpecifiedBenchmarks

[LebedevRI]

Technically not a hallucination, but somewhat bogus - API expects only a single call to RunSpecifiedBenchmarks().
Likewise, this happens even without any filter.

Failed to match any benchmarks against regex: 


=================================================================
==2814752==ERROR: AddressSanitizer: heap-use-after-free on address 0x7c7ff69eb2a8 at pc 0x5555557cf46e bp 0x7fffffffd510 sp 0x7fffffffd508
READ of size 8 at 0x7c7ff69eb2a8 thread T0
    #0 0x5555557cf46d in benchmark::BenchmarkReporter::GetOutputStream() const benchmark.cc
    #1 0x5555557c7555 in benchmark::RunSpecifiedBenchmarks(benchmark::BenchmarkReporter*, benchmark::BenchmarkReporter*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>) benchmark.cc
    #2 0x5555557c71ac in benchmark::RunSpecifiedBenchmarks() benchmark.cc
    #3 0x555555727ee6 in main complexity_test.cc
    #4 0x7ffff793bf76 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #5 0x7ffff793c026 in __libc_start_main csu/../csu/libc-start.c:360:3
    #6 0x555555635f00 in _start (/repositories/googlebenchmark/build/test/complexity_test+0xe1f00) (BuildId: 16144d6dbec0cda64a84f142809a81dc5933299c)

0x7c7ff69eb2a8 is located 8 bytes inside of 96-byte region [0x7c7ff69eb2a0,0x7c7ff69eb300)
freed by thread T0 here:
    #0 0x555555721006 in operator delete(void*, unsigned long) (/repositories/googlebenchmark/build/test/complexity_test+0x1cd006) (BuildId: 16144d6dbec0cda64a84f142809a81dc5933299c)
    #1 0x55555582d6a6 in benchmark::ConsoleReporter::~ConsoleReporter() console_reporter.cc
    #2 0x5555557d3696 in std::default_delete<benchmark::BenchmarkReporter>::operator()(benchmark::BenchmarkReporter*) const benchmark.cc
    #3 0x5555557cf38f in std::unique_ptr<benchmark::BenchmarkReporter, std::default_delete<benchmark::BenchmarkReporter>>::~unique_ptr() benchmark.cc
    #4 0x5555557c7c4e in benchmark::RunSpecifiedBenchmarks(benchmark::BenchmarkReporter*, benchmark::BenchmarkReporter*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>) benchmark.cc
    #5 0x5555557c71ac in benchmark::RunSpecifiedBenchmarks() benchmark.cc
    #6 0x555555727ee1 in main complexity_test.cc
    #7 0x7ffff793bf76 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16

previously allocated by thread T0 here:
    #0 0x555555720401 in operator new(unsigned long) (/repositories/googlebenchmark/build/test/complexity_test+0x1cc401) (BuildId: 16144d6dbec0cda64a84f142809a81dc5933299c)
    #1 0x5555557c6f7d in benchmark::internal::(anonymous namespace)::CreateReporter(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, benchmark::ConsoleReporter::OutputOptions) benchmark.cc
    #2 0x5555557c6e3e in benchmark::CreateDefaultDisplayReporter() benchmark.cc
    #3 0x5555557c7501 in benchmark::RunSpecifiedBenchmarks(benchmark::BenchmarkReporter*, benchmark::BenchmarkReporter*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>) benchmark.cc
    #4 0x5555557c71ac in benchmark::RunSpecifiedBenchmarks() benchmark.cc
    #5 0x555555727ee1 in main complexity_test.cc
    #6 0x7ffff793bf76 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16

SUMMARY: AddressSanitizer: heap-use-after-free benchmark.cc in benchmark::BenchmarkReporter::GetOutputStream() const
Shadow bytes around the buggy address:
  0x7c7ff69eb000: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fd
  0x7c7ff69eb080: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fa
  0x7c7ff69eb100: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fd
  0x7c7ff69eb180: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fd
  0x7c7ff69eb200: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fd
=>0x7c7ff69eb280: fa fa fa fa fd[fd]fd fd fd fd fd fd fd fd fd fd
  0x7c7ff69eb300: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fd
  0x7c7ff69eb380: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fd
  0x7c7ff69eb400: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fd
  0x7c7ff69eb480: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fd
  0x7c7ff69eb500: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==2814752==ABORTING
Aborted                    test/complexity_test