You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit follows up the previous commit [1], which aimed to improve
the code but ended up introducing an inverted null check in
time_zone_name_win.cc. As a result, LoadIcuGetTimeZoneIDForWindowsID()
currently returns nullptr when it should be returning a valid time zone
ID.
A unit test is also added, as the fallback chain in local_time_zone()
makes it difficult to verify the behavior of
LoadIcuGetTimeZoneIDForWindowsID() in isolation. The test ensures that
the function correctly returns a valid time zone ID on Windows.
This is also a preparation for implementing TimeZoneIf with Windows time
APIs (#328).
[1] 27ca173
0 commit comments