Internal Changes

RELNOTES=Introduced @asalias to allow @BINDS methods to "float"
PiperOrigin-RevId: 875335080

Author: trexem

dagger-compiler/main/java/dagger/internal/codegen/base/ComponentKind.java

@@ -98,4 +98,8 @@ public ImmutableSet<ComponentKind> legalSubcomponentKinds() {
   public boolean isProducer() {
     return PRODUCER_KINDS.contains(this);
   }
+
+  public boolean isSubcomponent() {
+    return this.equals(SUBCOMPONENT) || this.equals(PRODUCTION_SUBCOMPONENT);
+  }
 }

dagger-compiler/main/java/dagger/internal/codegen/binding/BindingGraphFactory.java

@@ -677,7 +677,7 @@ private final class RequiresResolutionChecker {
 
       boolean requiresResolution(BindingNode binding) {
         // If we're not allowed to float then the binding cannot be re-resolved in this component.
-        if (isNotAllowedToFloat(binding)) {
+        if (!isAllowedToFloat(binding)) {
           return false;
         }
         if (hasLocalBindings(binding)) {
@@ -692,14 +692,16 @@ boolean requiresResolution(BindingNode binding) {
             && (dependsOnLocalBinding(binding) || dependsOnMissingBinding(binding));
       }
 
-      private boolean isNotAllowedToFloat(BindingNode binding) {
+      private boolean isAllowedToFloat(BindingNode binding) {
+        if(binding.kind() == BindingKind.INJECTION
+            || binding.kind() == BindingKind.ASSISTED_INJECTION) {
+          return true;
+        }
         // In general, @Provides/@Binds/@Production bindings are allowed to float to get access to
         // multibinding contributions that are contributed in subcomponents. However, they aren't
         // allowed to float to get access to missing bindings that are installed in subcomponents,
         // so we prevent floating if these bindings depend on a missing binding.
-        return binding.kind() != BindingKind.INJECTION
-            && binding.kind() != BindingKind.ASSISTED_INJECTION
-            && dependsOnMissingBinding(binding);
+        return !dependsOnMissingBinding(binding);
       }
 
       private boolean dependsOnMissingBinding(BindingNode binding) {

dagger-compiler/main/java/dagger/internal/codegen/bindinggraphvalidation/BindingGraphValidationModule.java

@@ -44,7 +44,7 @@ static ImmutableSet<ValidationBindingGraphPlugin> providePlugins(
       ProvisionDependencyOnProducerBindingValidator validation9,
       InvalidProductionBindingScopeValidator validation10,
       SetMultibindingValidator validation11,
-      SubcomponentFactoryMethodValidator validation12) {
+    SubcomponentFactoryMethodValidator validation12) {
     ImmutableSet.Builder<ValidationBindingGraphPlugin> builder =
         ImmutableSet.<ValidationBindingGraphPlugin>builder()
             .add(validation1)