Skip to content

Commit adc7948

Browse files
trexemDagger Team
authored andcommitted
Internal Changes
RELNOTES=N/A PiperOrigin-RevId: 881486148
1 parent bac38be commit adc7948

1 file changed

Lines changed: 10 additions & 13 deletions

File tree

dagger-compiler/main/java/dagger/internal/codegen/validation/ComponentHierarchyValidator.java

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
import dagger.internal.codegen.compileroption.CompilerOptions;
4747
import dagger.internal.codegen.model.Scope;
4848
import java.util.Collection;
49-
import java.util.Formatter;
5049
import java.util.Map;
5150
import java.util.Optional;
5251
import javax.inject.Inject;
@@ -72,7 +71,6 @@ ValidationReport validate(ComponentDescriptor componentDescriptor) {
7271
componentDescriptor,
7372
Maps.toMap(componentDescriptor.moduleTypes(), constant(componentDescriptor.typeElement())));
7473
validateRepeatedScopedDeclarations(report, componentDescriptor, LinkedHashMultimap.create());
75-
7674
if (compilerOptions.scopeCycleValidationType().diagnosticKind().isPresent()) {
7775
validateScopeHierarchy(
7876
report, componentDescriptor, LinkedHashMultimap.<ComponentDescriptor, Scope>create());
@@ -190,26 +188,25 @@ private void validateProductionModuleUniqueness(
190188
}
191189
producerModulesByComponent.removeAll(componentDescriptor);
192190

193-
194191
SetMultimap<ComponentDescriptor, ModuleDescriptor> repeatedModules =
195192
Multimaps.filterValues(producerModulesByComponent, producerModules::contains);
196193
if (repeatedModules.isEmpty()) {
197194
return;
198195
}
199196

200-
StringBuilder error = new StringBuilder();
201-
Formatter formatter = new Formatter(error);
202-
203-
formatter.format(
204-
"%s repeats @ProducerModules:", componentDescriptor.typeElement().getQualifiedName());
197+
StringBuilder error =
198+
new StringBuilder()
199+
.append(componentDescriptor.typeElement().getQualifiedName())
200+
.append(" repeats @ProducerModules:");
205201

206202
for (Map.Entry<ComponentDescriptor, Collection<ModuleDescriptor>> entry :
207203
repeatedModules.asMap().entrySet()) {
208-
formatter.format("\n %s also installs: ", entry.getKey().typeElement().getQualifiedName());
209-
COMMA_SEPARATED_JOINER
210-
.appendTo(
211-
error,
212-
Iterables.transform(entry.getValue(), m -> m.moduleElement().getQualifiedName()));
204+
error
205+
.append("\n ")
206+
.append(entry.getKey().typeElement().getQualifiedName())
207+
.append(" also installs: ");
208+
COMMA_SEPARATED_JOINER.appendTo(
209+
error, Iterables.transform(entry.getValue(), m -> m.moduleElement().getQualifiedName()));
213210
}
214211

215212
report.addError(error.toString());

0 commit comments

Comments
 (0)