Don't flag Optional parameters inside @AutoValue.Builder.

PiperOrigin-RevId: 901286959

Author: kluever

core/src/main/java/com/google/errorprone/bugpatterns/NonApiType.java

@@ -25,6 +25,7 @@
 import static com.google.errorprone.predicates.TypePredicates.not;
 import static com.google.errorprone.util.ASTHelpers.getSymbol;
 import static com.google.errorprone.util.ASTHelpers.getType;
+import static com.google.errorprone.util.ASTHelpers.hasAnnotation;
 import static com.google.errorprone.util.ASTHelpers.isRecord;
 import static com.google.errorprone.util.ASTHelpers.isSameType;
 import static com.google.errorprone.util.ASTHelpers.methodIsPublicAndNotAnOverride;
@@ -88,7 +89,11 @@ public final class NonApiType extends BugChecker implements MethodTreeMatcher {
           // Optionals
           withPublicVisibility(
               isExactType("java.util.Optional"),
-              NON_GRAPH_WRAPPER,
+              (type, state) ->
+                  NON_GRAPH_WRAPPER.apply(type, state)
+                      // NOTE(b/503669492): allow Optional parameters in @AutoValue.Builder methods
+                      && !hasAnnotation(
+                          type.tsym, "com.google.auto.value.AutoValue.Builder", state),
               "Avoid Optional parameters. " + OPTIONAL_AS_PARAM_LINK,
               ApiElementType.PARAMETER),
           withPublicVisibility(

core/src/test/java/com/google/errorprone/bugpatterns/NonApiTypeTest.java

@@ -163,8 +163,6 @@ public abstract class User {
 
               @AutoValue.Builder
               public abstract static class Builder {
-                // TODO(b/503669492): we probably shouldn't flag this!
-                // BUG: Diagnostic contains: Avoid Optional parameters
                 public abstract Builder setMiddleName(Optional<String> middleName);
 
                 public abstract User build();