Skip to content

Commit 34ff9a7

Browse files
Fix firebase emulator failing CI (#3613)
1 parent 11296bf commit 34ff9a7

2 files changed

Lines changed: 21 additions & 8 deletions

File tree

.github/actions/submit-test/action.yml

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ runs:
5555
exit 1
5656
fi
5757
echo "MAPS_API_KEY is set"
58-
echo "MAPS_API_KEY=${{ secrets.MAPS_API_KEY }}" > secrets.properties
58+
echo "MAPS_API_KEY=${MAPS_API_KEY}" > secrets.properties
5959
6060
- name: Enable KVM group perms
6161
shell: bash
@@ -106,12 +106,23 @@ runs:
106106
if-no-files-found: ignore
107107

108108
- name: Export Firebase emulator data
109-
if: always()
110109
shell: bash
110+
if: always()
111+
continue-on-error: true
111112
run: |
112113
echo "Exporting emulator data..."
113114
npx -y -p firebase-tools firebase emulators:export ${{ github.workspace }}/test-android-result --project demo-local --force
114115
116+
- name: Upload Firebase emulator log
117+
if: always() && inputs.upload-artifacts == 'true'
118+
continue-on-error: true
119+
uses: actions/upload-artifact@v6
120+
with:
121+
name: firebase-emulator-log
122+
path: /tmp/firebase-emulator.log
123+
retention-days: 7
124+
if-no-files-found: warn
125+
115126
- name: Upload Firebase emulator data
116127
if: always() && inputs.upload-artifacts == 'true'
117128
uses: actions/upload-artifact@v6

.github/workflows/test-e2e.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,17 @@ jobs:
3333

3434
# See docs/e2e-testing-doc.md for details on how this is setup
3535
steps:
36-
- name: Checkout repository
37-
uses: actions/checkout@v6
38-
3936
- name: Start Firebase emulator
4037
uses: google/ground-platform/.github/actions/start-emulator@master
38+
with:
39+
platform-repository: google/ground-platform
40+
41+
- name: Restore workflow repository
42+
uses: actions/checkout@v6
4143

4244
- name: Run Android tests on e2eTest module
43-
uses: google/ground-android/.github/actions/submit-test@master
45+
uses: ./.github/actions/submit-test
4446
with:
45-
android-repository: ${{ github.repository }}
47+
android-repository: google/ground-android
4648
upload-artifacts: true
47-
google-maps-key: ${{ secrets.MAPS_API_KEY }}
49+
google-maps-key: ${{ secrets.MAPS_API_KEY }}

0 commit comments

Comments
 (0)