chore: fix cast conformance in C++23

jcpunk · jcpunk · commit 2138da806ead · 2026-03-27T13:40:49.000-05:00
diff --git a/core/unicode_test.cpp b/core/unicode_test.cpp
@@ -105,7 +105,8 @@ TEST(Unicode, TestUTF8RoundTripExhaustive)
         size_t at = 0;
         char32_t y = decode_utf8(buffer, at);
         EXPECT_NE(y, JSONNET_CODEPOINT_ERROR) << "UTF-8 roundtrip failed for codepoint " << x << " decode rejects" << std::endl;
-        EXPECT_EQ(x, y) << "UTF-8 roundtrip failed for codepoint " << x << " converts to " << y << std::endl;
+        EXPECT_EQ(x, y) << "UTF-8 roundtrip failed for codepoint " << static_cast<uint32_t>(x)
+                        << " converts to " << static_cast<uint32_t>(y) << std::endl;
         EXPECT_EQ(at, buffer.size() - 1) << "UTF-8 roundtrip failed for codepoint " << x << " decodes incorrect length" << std::endl;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,8 @@ TEST(Unicode, TestUTF8RoundTripExhaustive)`
`105`	`105`	`size_t at = 0;`
`106`	`106`	`char32_t y = decode_utf8(buffer, at);`
`107`	`107`	`EXPECT_NE(y, JSONNET_CODEPOINT_ERROR) << "UTF-8 roundtrip failed for codepoint " << x << " decode rejects" << std::endl;`
`108`		`- EXPECT_EQ(x, y) << "UTF-8 roundtrip failed for codepoint " << x << " converts to " << y << std::endl;`
	`108`	`+ EXPECT_EQ(x, y) << "UTF-8 roundtrip failed for codepoint " << static_cast<uint32_t>(x)`
	`109`	`+ << " converts to " << static_cast<uint32_t>(y) << std::endl;`
`109`	`110`	`EXPECT_EQ(at, buffer.size() - 1) << "UTF-8 roundtrip failed for codepoint " << x << " decodes incorrect length" << std::endl;`
`110`	`111`	`}`
`111`	`112`	`}`