print names of unclean files in jsonnetfmt --test and --in-place

And add test_cmd test cases for it

Fixes #365

Go-jsonnet feature request for it: google/go-jsonnet#768

Author: johnbartholomew

cmd/jsonnetfmt.cpp

@@ -231,6 +231,7 @@ int main(int argc, const char **argv)
         std::string output_file = config.outputFile;
 
         if (config.fmtInPlace || config.fmtTest) {
+            bool changed_files = false;
             assert(config.inputFiles.size() >= 1);
             for (std::string &inputFile : config.inputFiles) {
                 if (config.fmtInPlace) {
@@ -269,8 +270,10 @@ int main(int argc, const char **argv)
                     bool ok = output == input;
                     jsonnet_realloc(vm, output, 0);
                     if (!ok) {
-                        jsonnet_destroy(vm);
-                        return 2;
+                        if (inputFile != "-" && !config.filenameIsCode) {
+                            std::cout << inputFile << std::endl;
+                        }
+                        changed_files = true;
                     }
                 } else {
                     // Write output Jsonnet only if there is a difference between input and output
@@ -282,11 +285,19 @@ int main(int argc, const char **argv)
                             jsonnet_destroy(vm);
                             return EXIT_FAILURE;
                         }
+                        if (inputFile != "-" && !config.filenameIsCode) {
+                            std::cout << inputFile << std::endl;
+                        }
                     } else {
                         jsonnet_realloc(vm, output, 0);
                     }
                 }
             }
+
+            if (config.fmtTest && changed_files) {
+                jsonnet_destroy(vm);
+                return 2;
+            }
         } else {
             assert(config.inputFiles.size() == 1);
             // Read input file.

test_cmd/fmt_inplace.golden.stdout

@@ -0,0 +1 @@
+out/fmt_inplace/test_badfmt.jsonnet

test_cmd/fmt_simple_test1.golden.stdout

@@ -0,0 +1 @@
+test_badfmt.jsonnet

test_cmd/fmt_simple_test2.golden.stdout

@@ -27,6 +27,8 @@ source "${DIR}/cmd_tests.source"
 OUT_DIR=$(mktemp -d)
 trap "rm -rf -- ${OUT_DIR}" EXIT INT TERM
 
+>&2 echo "output dir: ${OUT_DIR}"
+
 pushd "${DIR}"
 
 [[ -d "${OUT_DIR}" ]] || {
@@ -174,17 +176,25 @@ if do_fmt_test "fmt_out" 0 -e "{ a: 1, b: 2, c: 3 }" -o "${OUT_DIR}/fmt_out/cust
 fi
 do_fmt_test "fmt_double_dash" 0 -e -- -1
 
-if mkdir -p "${OUT_DIR}/fmt_inplace" && cp "test.jsonnet" "${OUT_DIR}/fmt_inplace/test.jsonnet"; then
+do_fmt_test "fmt_simple_test1" 0 --test "test.jsonnet"
+do_fmt_test "fmt_simple_test2" 2 --test -e "{a:1,b:2,c:3}"
+do_fmt_test "fmt_simple_test3" 0 --test -e $'42\n'
+do_fmt_test "fmt_simple_test4" 2 --test "test.jsonnet" "test_badfmt.jsonnet"
+
+SED_STDOUT="${SED_REPLACE_OUT_DIR}"
+if mkdir -p "${OUT_DIR}/fmt_inplace" && cp "test.jsonnet" "test_badfmt.jsonnet" "${OUT_DIR}/fmt_inplace/"; then
     # Test jsonnetfmt in-place modifications
-    do_fmt_test "fmt_inplace" 0 -i "${OUT_DIR}/fmt_inplace/test.jsonnet"
     check_file "fmt_inplace" "${OUT_DIR}/fmt_inplace/test.jsonnet" "fmt_simple_out.golden.custom_output"
     # Verify that running jsonnetfmt on an already formatted file does not change timesetamps
     touch -m -t 199108252057.08 "${OUT_DIR}/fmt_inplace/test.jsonnet"
+    touch -m -t 199108252057.08 "${OUT_DIR}/fmt_inplace/test_badfmt.jsonnet"
     stat -c '%y' "${OUT_DIR}/fmt_inplace/test.jsonnet" > "${OUT_DIR}/fmt_inplace/stat_mod_time_before.txt"
-    do_fmt_test "fmt_inplace" 0 -i "${OUT_DIR}/fmt_inplace/test.jsonnet"
+    do_fmt_test "fmt_inplace" 0 -i \
+        "${OUT_DIR}/fmt_inplace/test.jsonnet" "${OUT_DIR}/fmt_inplace/test_badfmt.jsonnet"
     stat -c '%y' "${OUT_DIR}/fmt_inplace/test.jsonnet" > "${OUT_DIR}/fmt_inplace/stat_mod_time_after.txt"
     check_file "fmt_inplace" "${OUT_DIR}/fmt_inplace/stat_mod_time_before.txt" "${OUT_DIR}/fmt_inplace/stat_mod_time_after.txt"
 fi
+unset -v SED_STDOUT
 
 fi
 

test_cmd/fmt_simple_test3.golden.stdout

@@ -0,0 +1,3 @@
+{a:1, b:
+
+2,['c']:3}