From 7c7612db4e1439ccf179ec16fb6af6edc16ed88a Mon Sep 17 00:00:00 2001
From: Sachin Purohit <sachinpurohit@google.com>
Date: Mon, 13 Jul 2026 22:12:23 +0000
Subject: [PATCH] fix: release builds should upload package after failing
 integration tests

---
 .github/workflows/windows-release.yml     | 9 +++++++++
 ci/cloudbuild/builds/bq-driver-release.sh | 5 ++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/windows-release.yml b/.github/workflows/windows-release.yml
index 23b308d3eb..9c1d10630c 100644
--- a/.github/workflows/windows-release.yml
+++ b/.github/workflows/windows-release.yml
@@ -253,6 +253,8 @@ jobs:
         Write-Output "DSN creation completed."
 
     - name: Running testcases
+      id: tests
+      continue-on-error: true
       shell: bash
       run: |
         export VCPKG_ROOT="${TEMP}/.build/vcpkg"
@@ -300,3 +302,10 @@ jobs:
         gsutil -m cp `
           "$MSI_DIR/$MSI_FILE" `
           "gs://$env:GCS_BUCKET/odbc-windows/$arch/$MSI_FILE"
+
+    - name: Check test results
+      if: steps.tests.outcome == 'failure'
+      shell: bash
+      run: |
+        echo "Tests failed!"
+        exit 1
diff --git a/ci/cloudbuild/builds/bq-driver-release.sh b/ci/cloudbuild/builds/bq-driver-release.sh
index a18385d934..e9cb09e82f 100755
--- a/ci/cloudbuild/builds/bq-driver-release.sh
+++ b/ci/cloudbuild/builds/bq-driver-release.sh
@@ -83,7 +83,8 @@ io::run cmake --build cmake-out
 # Copy the roots.pem file to the .so directory to run test cases.
 cp /opt/odbc-driver/roots.pem "cmake-out/google/cloud/odbc/roots.pem"
 mapfile -t ctest_args < <(ctest::common_args)
-io::run env -C cmake-out ctest "${ctest_args[@]}"
+TESTS_EXIT_CODE=0
+io::run env -C cmake-out ctest "${ctest_args[@]}" || TESTS_EXIT_CODE=$?
 
 io::log_h1 "Packaging and Uploading Driver"
 
@@ -112,3 +113,5 @@ io::log "ZIP package created: ${ZIP_NAME}"
 export GCS_BUCKET=bq_devtools_release_private
 io::log "Uploading ${ZIP_NAME} to gs://${GCS_BUCKET}/drivers/odbc/linux/"
 io::run gsutil -m cp "${ZIP_NAME}" "gs://${GCS_BUCKET}/drivers/odbc/linux/"
+
+exit "${TESTS_EXIT_CODE}"