Skip to content

Commit d0299ec

Browse files
committed
Addressed Lawrence's comments on RAB PR.
1 parent 5c41934 commit d0299ec

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

oauth2_http/java/com/google/auth/oauth2/RegionalAccessBoundary.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@
6262
* infrastructure to enforce regional security restrictions. This class does not perform any
6363
* client-side validation or enforcement.
6464
*/
65-
public final class RegionalAccessBoundary implements Serializable {
65+
final class RegionalAccessBoundary implements Serializable {
6666

67-
public static final String X_ALLOWED_LOCATIONS_HEADER_KEY = "x-allowed-locations";
67+
static final String X_ALLOWED_LOCATIONS_HEADER_KEY = "x-allowed-locations";
6868
private static final long serialVersionUID = -2428522338274020302L;
6969

7070
// Note: this is for internal testing use use only.

oauth2_http/java/com/google/auth/oauth2/RegionalAccessBoundaryManager.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,10 +172,10 @@ void triggerAsyncRefresh(
172172
} catch (Exception | Error e) {
173173
// If scheduling fails (e.g., RejectedExecutionException, OutOfMemoryError for threads),
174174
// the task's finally block will never execute. We must release the lock here.
175-
refreshFuture.set(null);
176-
future.setException(e);
177175
handleRefreshFailure(
178176
new Exception("Regional Access Boundary background refresh failed to schedule", e));
177+
future.setException(e);
178+
refreshFuture.set(null);
179179
}
180180
}
181181
}
@@ -203,7 +203,7 @@ private void handleRefreshFailure(Exception e) {
203203
if (cooldownState.compareAndSet(currentCooldownState, next)) {
204204
LoggingUtils.log(
205205
LOGGER_PROVIDER,
206-
Level.INFO,
206+
Level.FINE,
207207
null,
208208
"Regional Access Boundary lookup failed; entering cooldown for "
209209
+ (next.durationMillis / 60000)

0 commit comments

Comments
 (0)