Skip to content

Commit 41f837c

Browse files
chore: remove deprecated VERSION constants (#9086)
1 parent 269323e commit 41f837c

10 files changed

Lines changed: 15 additions & 14 deletions

File tree

Datastore/MIGRATING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ Update your `google/cloud-datastore` dependency to `^2.0`:
1414

1515
## Breaking Changes
1616

17+
### Version constant removed
18+
Removed `DatastoreClient::VERSION`, use the `VERSION` file in the library root instead.
19+
1720
### EntityInterface changes
1821

1922
Types have been added to the methods in [`EntityInterface`](src/EntityInterface.php). This means that
@@ -148,4 +151,3 @@ to the namespaced version (replacing `_` with `\`) to upgrade.
148151
- `Google\Cloud\Datastore\V1\ReadOptions_ReadConsistency` has been removed
149152
- `Google\Cloud\Datastore\V1\Key_PathElement` has been removed
150153
- `Google\Cloud\Datastore\V1\AggregationQuery_Aggregation_Count` has been removed
151-

Datastore/src/DatastoreClient.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,6 @@ class DatastoreClient
9797
use ClientOptionsTrait;
9898
use EmulatorTrait;
9999

100-
const VERSION = '2.0.0-RC1';
101-
102100
const FULL_CONTROL_SCOPE = 'https://www.googleapis.com/auth/datastore';
103101

104102
/**

Firestore/MIGRATING.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,3 +108,6 @@ $batch = new BulkWriter(...);
108108
| Class Constructors | Accepted `ConnectionInterface` | Accept `V1\Client\FirestoreClient` | Update arguments passed to constructors. |
109109

110110
By addressing these key areas, you can successfully migrate your application to version 2 of the Firestore client library.
111+
112+
## 5. Version constant removed
113+
Removed `FirestoreClient::VERSION`, use the `VERSION` file in the library root instead.

Firestore/src/FirestoreClient.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ class FirestoreClient
8888
use ClientOptionsTrait;
8989
use RequestProcessorTrait;
9090

91-
const VERSION = '2.0.0-RC1';
92-
9391
const DEFAULT_DATABASE = '(default)';
9492
const FULL_CONTROL_SCOPE = 'https://www.googleapis.com/auth/cloud-platform';
9593
const MAX_RETRIES = 5;

Logging/MIGRATING.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ Update your `google/cloud-logging` dependency to `^2.0`:
1414

1515
## Changes
1616

17+
### Version constant removed
18+
Removed `LoggingClient::VERSION`, use the `VERSION` file in the library root instead.
19+
1720
### Client Options changes
1821

1922
The following client options are removed/replaced with other options present in
@@ -52,5 +55,3 @@ This is a major change, but one that we hope won't break any users. When the
5255
The Rest and Grpc connection classes (along with the `ConnectionInterface`) have been
5356
removed in favor of using the GAPIC generated clients directly. See `src/Connection/Gapic.php`
5457
for an example.
55-
56-

Logging/src/LoggingClient.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ class LoggingClient
6767
use DetectProjectIdTrait;
6868
use ClientOptionsTrait;
6969

70-
const VERSION = '2.0.0-RC1';
71-
7270
const FULL_CONTROL_SCOPE = 'https://www.googleapis.com/auth/logging.admin';
7371
const READ_ONLY_SCOPE = 'https://www.googleapis.com/auth/logging.read';
7472
const WRITE_ONLY_SCOPE = 'https://www.googleapis.com/auth/logging.write';

PubSub/MIGRATING.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ Update your `google/cloud-pubsub` dependency to `^2.0`:
1414

1515
## Changes
1616

17+
### Version constant removed
18+
Removed `PubSubClient::VERSION`, use the `VERSION` file in the library root instead.
19+
1720
### Client Options changes
1821

1922
The following client options are removed/replaced with other options present in

PubSub/src/PubSubClient.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ class PubSubClient
9898
use ApiHelperTrait;
9999
use ClientOptionsTrait;
100100

101-
const VERSION = '2.19.1';
102-
103101
const FULL_CONTROL_SCOPE = 'https://www.googleapis.com/auth/pubsub';
104102

105103
private const GAPIC_KEYS = [

Spanner/MIGRATING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ Update your `google/cloud-spanner` dependency to `^2.0`:
1414

1515
## Changes
1616

17+
### Version constant removed
18+
Removed `SpannerClient::VERSION`, use the `VERSION` file in the library root instead.
19+
1720
### Client Options changes
1821

1922
The following client options are removed/replaced with other options present in
@@ -133,4 +136,3 @@ $lro->delete();
133136
- `Session\CacheSessionPool` => removed in favor of `SessionCache`
134137
- `Session\SessionPoolInterface` => removed in favor of `SessionCache`
135138
- `Operation` - this class is marked `@internal`, and should not be used directly.
136-

Spanner/src/SpannerClient.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,6 @@ class SpannerClient
114114
use ApiHelperTrait;
115115
use RequestTrait;
116116

117-
const VERSION = '2.0.0-RC1';
118-
119117
const FULL_CONTROL_SCOPE = 'https://www.googleapis.com/auth/spanner.data';
120118
const ADMIN_SCOPE = 'https://www.googleapis.com/auth/spanner.admin';
121119
private const GRPC_KEEPALIVE_MILLISECONDS = 120 * 1000;

0 commit comments

Comments
 (0)