From edb9d2763f4c52ab3b6378e31928ffc14a5285fd Mon Sep 17 00:00:00 2001 From: Sakthivel Subramanian Date: Tue, 19 May 2026 12:04:50 +0000 Subject: [PATCH] chore: fix lint failures in spanner samples --- .../samples/samples/archived/backup_snippet_test.py | 1 + .../google-cloud-spanner/samples/samples/autocommit_test.py | 1 - packages/google-cloud-spanner/samples/samples/conftest.py | 1 + .../samples/samples/graph_snippets_test.py | 1 + .../google-cloud-spanner/samples/samples/quickstart_test.py | 3 --- 5 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/google-cloud-spanner/samples/samples/archived/backup_snippet_test.py b/packages/google-cloud-spanner/samples/samples/archived/backup_snippet_test.py index a6fc712696bd..39b46b8bb8bd 100644 --- a/packages/google-cloud-spanner/samples/samples/archived/backup_snippet_test.py +++ b/packages/google-cloud-spanner/samples/samples/archived/backup_snippet_test.py @@ -18,6 +18,7 @@ from google.api_core.exceptions import DeadlineExceeded from test_utils.retry import RetryErrors + def unique_database_id(): """Creates a unique id for the database.""" return f"test-db-{uuid.uuid4().hex[:10]}" diff --git a/packages/google-cloud-spanner/samples/samples/autocommit_test.py b/packages/google-cloud-spanner/samples/samples/autocommit_test.py index cf95bab2e038..0e1b97abd1bd 100644 --- a/packages/google-cloud-spanner/samples/samples/autocommit_test.py +++ b/packages/google-cloud-spanner/samples/samples/autocommit_test.py @@ -5,7 +5,6 @@ # https://developers.google.com/open-source/licenses/bsd from google.api_core.exceptions import Aborted -import pytest from test_utils.retry import RetryErrors import autocommit diff --git a/packages/google-cloud-spanner/samples/samples/conftest.py b/packages/google-cloud-spanner/samples/samples/conftest.py index 2e5afc1de7fb..ba0f9132038e 100644 --- a/packages/google-cloud-spanner/samples/samples/conftest.py +++ b/packages/google-cloud-spanner/samples/samples/conftest.py @@ -33,6 +33,7 @@ (exceptions.ResourceExhausted, exceptions.FailedPrecondition), max_tries=6, delay=15 ) + @pytest.fixture(scope="module") def database_dialect(): """Database dialect to be used for this sample. diff --git a/packages/google-cloud-spanner/samples/samples/graph_snippets_test.py b/packages/google-cloud-spanner/samples/samples/graph_snippets_test.py index 23a8cb687e78..436d592e1b11 100644 --- a/packages/google-cloud-spanner/samples/samples/graph_snippets_test.py +++ b/packages/google-cloud-spanner/samples/samples/graph_snippets_test.py @@ -80,6 +80,7 @@ LABEL Transfers) """ + @pytest.fixture(scope="module") def database_dialect(): """Spanner dialect to be used for this sample. diff --git a/packages/google-cloud-spanner/samples/samples/quickstart_test.py b/packages/google-cloud-spanner/samples/samples/quickstart_test.py index 3b1e31b27867..fdb4ed3d9100 100644 --- a/packages/google-cloud-spanner/samples/samples/quickstart_test.py +++ b/packages/google-cloud-spanner/samples/samples/quickstart_test.py @@ -11,9 +11,6 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. - -import pytest - import quickstart