Skip to content

Commit f7a5c44

Browse files
quartzmoquartzmo
authored
Upgrade Rubocop to 0.59.2 (#2525)
* Update rubocop Lint/RescueWithoutErrorClass to new name. * Disable Layout/EmptyLineAfterGuardClause cop where failing * Disable Naming/UncommunicativeMethodParamName cop where failing * Locally disable MultipleComparison cop where failing * Remove blank line from bigtable/instance.rb * Fix code alignment in core/config.rb * Fix rubocop errors in debugger * Fix rubocop errors in spanner * Remove require 'thread' statements [closes #2136]
1 parent a65607a commit f7a5c44

71 files changed

Lines changed: 113 additions & 65 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Gemfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ gem "minitest-focus", "~> 1.1"
77
gem "minitest-rg", "~> 5.2"
88
gem "autotest-suffix", "~> 1.1"
99
gem "redcarpet", "~> 3.0"
10-
gem "rubocop", "~> 0.50.0"
10+
gem "rubocop", "~> 0.59.2"
1111
gem "simplecov", "~> 0.16"
1212
gem "codecov", "~> 0.1", require: false
1313
gem "yard", "~> 0.9"

‎gcloud/gcloud.gemspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Gem::Specification.new do |gem|
2626
gem.add_development_dependency "minitest-rg", "~> 5.2"
2727
gem.add_development_dependency "autotest-suffix", "~> 1.1"
2828
gem.add_development_dependency "redcarpet", "~> 3.0"
29-
gem.add_development_dependency "rubocop", "~> 0.50.0"
29+
gem.add_development_dependency "rubocop", "~> 0.59.2"
3030
gem.add_development_dependency "simplecov", "~> 0.9"
3131
gem.add_development_dependency "yard", "~> 0.9"
3232
gem.add_development_dependency "yard-doctest", "~> 0.1.13"

‎google-cloud-asset/google-cloud-asset.gemspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Gem::Specification.new do |gem|
2525

2626
gem.add_development_dependency "minitest", "~> 5.10"
2727
gem.add_development_dependency "redcarpet", "~> 3.0"
28-
gem.add_development_dependency "rubocop", "~> 0.50.0"
28+
gem.add_development_dependency "rubocop", "~> 0.59.2"
2929
gem.add_development_dependency "simplecov", "~> 0.9"
3030
gem.add_development_dependency "yard", "~> 0.9"
3131
end

‎google-cloud-bigquery-data_transfer/google-cloud-bigquery-data_transfer.gemspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Gem::Specification.new do |gem|
2424

2525
gem.add_development_dependency "minitest", "~> 5.10"
2626
gem.add_development_dependency "redcarpet", "~> 3.0"
27-
gem.add_development_dependency "rubocop", "~> 0.50.0"
27+
gem.add_development_dependency "rubocop", "~> 0.59.2"
2828
gem.add_development_dependency "simplecov", "~> 0.9"
2929
gem.add_development_dependency "yard", "~> 0.9"
3030
end

‎google-cloud-bigquery/.rubocop.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,12 @@ Metrics/MethodLength:
3030
Max: 30
3131
Metrics/ParameterLists:
3232
Enabled: false
33+
Layout/EmptyLineAfterGuardClause:
34+
Enabled: false
3335
Layout/EmptyLines: # for the extra line between copyright and code
3436
Enabled: false
3537
Naming/FileName:
3638
Exclude:
3739
- "lib/google-cloud-bigquery.rb"
40+
Naming/UncommunicativeMethodParamName:
41+
Enabled: false

‎google-cloud-bigquery/google-cloud-bigquery.gemspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Gem::Specification.new do |gem|
2929
gem.add_development_dependency "minitest-rg", "~> 5.2"
3030
gem.add_development_dependency "autotest-suffix", "~> 1.1"
3131
gem.add_development_dependency "redcarpet", "~> 3.0"
32-
gem.add_development_dependency "rubocop", "~> 0.50.0"
32+
gem.add_development_dependency "rubocop", "~> 0.59.2"
3333
gem.add_development_dependency "simplecov", "~> 0.9"
3434
gem.add_development_dependency "yard", "~> 0.9"
3535
gem.add_development_dependency "yard-doctest", "~> 0.1.13"

‎google-cloud-bigtable/.rubocop.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ Metrics/MethodLength:
4040
Max: 30
4141
Metrics/ParameterLists:
4242
Enabled: false
43+
Layout/EmptyLineAfterGuardClause:
44+
Enabled: false
4345
Layout/EmptyLines: # for the extra line between copyright and code
4446
Enabled: false
4547
Naming/FileName:

‎google-cloud-bigtable/google-cloud-bigtable.gemspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Gem::Specification.new do |gem|
2929
gem.add_development_dependency "minitest-focus", "~> 1.1"
3030
gem.add_development_dependency "minitest-rg", "~> 5.2"
3131
gem.add_development_dependency "redcarpet", "~> 3.0"
32-
gem.add_development_dependency "rubocop", "~> 0.50.0"
32+
gem.add_development_dependency "rubocop", "~> 0.59.2"
3333
gem.add_development_dependency "simplecov", "~> 0.9"
3434
gem.add_development_dependency "yard", "~> 0.9"
3535
gem.add_development_dependency "yard-doctest", "~> 0.1.13"

‎google-cloud-bigtable/lib/google/cloud/bigtable/instance.rb‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,6 @@ def tables
491491
# ).delete_from_column("cf2", "field02")
492492
#
493493
# table.mutate_row(entry)
494-
495494
#
496495
def table table_id, view: nil, perform_lookup: nil, app_profile_id: nil
497496
ensure_service!

‎google-cloud-container/google-cloud-container.gemspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Gem::Specification.new do |gem|
2424

2525
gem.add_development_dependency "minitest", "~> 5.10"
2626
gem.add_development_dependency "redcarpet", "~> 3.0"
27-
gem.add_development_dependency "rubocop", "~> 0.50.0"
27+
gem.add_development_dependency "rubocop", "~> 0.59.2"
2828
gem.add_development_dependency "simplecov", "~> 0.9"
2929
gem.add_development_dependency "yard", "~> 0.9"
3030
end

0 commit comments

Comments
 (0)