Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Commit 346f14d

Browse files
committed
Update all makefile commands
1 parent 70a91d5 commit 346f14d

3 files changed

Lines changed: 21 additions & 20 deletions

File tree

.gitignore

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,8 @@ __pycache__
1212
SimpleBenchmarkApp/src/main/java/com/google/cloud/App.java
1313
.flattened-pom.xml
1414
# Local Test files
15-
*ITLocalTest.java
15+
*ITLocalTest.java
16+
17+
# JDBC-specific files
18+
google-cloud-bigquery-jdbc/drivers/
19+
google-cloud-bigquery-jdbc/jacoco*

google-cloud-bigquery-jdbc/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ COPY ./google-cloud-bigquery-bom /src/google-cloud-bigquery-bom
1414

1515

1616
WORKDIR /src
17-
RUN mvn install
17+
RUN mvn install -DskipTests
1818

1919
WORKDIR /src/google-cloud-bigquery-jdbc
2020

google-cloud-bigquery-jdbc/Makefile

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
SECRET=`cat $(GOOGLE_APPLICATION_CREDENTIALS)`
22
CONTAINER_NAME=jdbc
3-
PACKAGE_DESTINATION=$(PWD)/bigquery-external-jdbc-tests/drivers
3+
PACKAGE_DESTINATION=$(PWD)/drivers
4+
SRC="$(PWD)/.."
45
skipSurefire ?= true
56

67
# no indendation for ifndef\endif due to their evaluation before execution
@@ -41,21 +42,20 @@ integration-test: .check-env
4142

4243
unit-test-coverage:
4344
$(MAKE) unittest
44-
mvn -B -ntp --projects=google-cloud-bigquery-jdbc jacoco:report
45-
BUILD_DIR=$$(mvn -B -ntp --projects=google-cloud-bigquery-jdbc help:evaluate -Dexpression=project.build.directory -q -DforceStdout); \
45+
mvn -B -ntp jacoco:report
46+
BUILD_DIR=$$(mvn -B -ntp help:evaluate -Dexpression=project.build.directory -q -DforceStdout); \
4647
cd $$BUILD_DIR/site && zip -r $$OLDPWD/jacoco-unittests.zip jacoco && cd $$OLDPWD
4748

4849
full-coverage: .check-env
4950
$(MAKE) integration-test skipSurefire=false test=ITBigQueryJDBCTest,ITNightlyBigQueryTest
50-
mvn -B -ntp --projects=google-cloud-bigquery-jdbc jacoco:report
51-
BUILD_DIR=$$(mvn -B -ntp --projects=google-cloud-bigquery-jdbc help:evaluate -Dexpression=project.build.directory -q -DforceStdout); \
51+
mvn -B -ntp jacoco:report
52+
BUILD_DIR=$$(mvn -B -ntp help:evaluate -Dexpression=project.build.directory -q -DforceStdout); \
5253
cd $$BUILD_DIR/site && zip -r $$OLDPWD/jacoco-full.zip jacoco && cd $$OLDPWD
5354

5455
package:
5556
mvn clean package \
5657
-DincludeScope=runtime \
57-
-Dmaven.test.skip=true \
58-
--projects=google-cloud-bigquery-jdbc
58+
-Dmaven.test.skip=true
5959
mvn dependency:copy-dependencies \
6060
-DincludeScope=runtime
6161
${MAKE} generate-dependency-list
@@ -64,20 +64,17 @@ package-all-dependencies:
6464
mvn package \
6565
-DincludeScope=runtime \
6666
-Dmaven.test.skip=true \
67-
-P=release-all-dependencies \
68-
--projects=google-cloud-bigquery-jdbc
67+
-P=release-all-dependencies
6968

7069
package-all-dependencies-shaded:
7170
mvn package \
7271
-DincludeScope=runtime \
7372
-Dmaven.test.skip=true \
74-
-P=release-all-dependencies,release-all-dependencies-shaded \
75-
--projects=google-cloud-bigquery-jdbc
73+
-P=release-all-dependencies,release-all-dependencies-shaded
7674

7775
generate-dependency-list:
7876
mvn -B dependency:list \
79-
-f google-cloud-bigquery-jdbc/pom.xml \
80-
-DexcludeTransitive \
77+
-f pom.xml \
8178
-DincludeScope=runtime | grep :jar: | sed -E "s/^.* ([^: ]+):([^:]+):([^:]+):([^:]+).*/<dependency><groupId>\1<\/groupId><artifactId>\2<\/artifactId><version>\4<\/version><\/dependency>/g" > dependencies.txt
8279

8380
# Commands for dockerized environments
@@ -86,7 +83,7 @@ generate-dependency-list:
8683
-v $(GOOGLE_APPLICATION_CREDENTIALS):/auth/application_creds.json \
8784
-v "$(GOOGLE_APPLICATION_CREDENTIALS).p12":/auth/application_creds.p12 \
8885
-e "GOOGLE_APPLICATION_CREDENTIALS=/auth/application_creds.json" \
89-
-v $(PWD)/..:/src \
86+
-v $(SRC):/src \
9087
-e "SA_EMAIL=test_email" \
9188
-e "SA_SECRET=$(SECRET)" \
9289
-e "SA_SECRET_P12=/auth/application_creds.p12" \
@@ -101,7 +98,7 @@ docker-session:
10198
docker-package-all-dependencies: docker-build
10299
mkdir -p $(PACKAGE_DESTINATION)
103100
docker run \
104-
-v $(PWD):/src \
101+
-v $(SRC):/src \
105102
-v $(PACKAGE_DESTINATION):/pkg \
106103
$(CONTAINER_NAME) \
107104
sh -c "make package-all-dependencies && \
@@ -111,17 +108,17 @@ docker-package-all-dependencies: docker-build
111108
docker-package-all-dependencies-shaded: docker-build
112109
mkdir -p $(PACKAGE_DESTINATION)
113110
docker run \
114-
-v $(PWD):/src \
111+
-v $(SRC):/src \
115112
-v $(PACKAGE_DESTINATION):/pkg \
116113
$(CONTAINER_NAME) \
117114
sh -c "make package-all-dependencies-shaded && \
118115
cp --no-preserve=ownership /mvn/test-target/google-cloud-bigquery-jdbc-*.jar /pkg && \
119116
rm -f /pkg/*tests.jar"
120117

121118
docker-package: docker-build
122-
mkdir -p bigquery-external-jdbc-tests/drivers/
119+
mkdir -p $(PACKAGE_DESTINATION)
123120
docker run \
124-
-v $(PWD):/src \
121+
-v $(SRC):/src \
125122
-v $(PACKAGE_DESTINATION):/pkg \
126123
$(CONTAINER_NAME) \
127124
sh -c "make package && \

0 commit comments

Comments
 (0)