Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Commit 45f8b8f

Browse files
committed
change datasetId key to dataset
1 parent 11fb8b7 commit 45f8b8f

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ && getOptions().getOpenTelemetryTracer() != null) {
566566
getOptions()
567567
.getOpenTelemetryTracer()
568568
.spanBuilder("JAVA_BQ_SDK_datasetGet")
569-
.setAllAttributes(datasetId.getOtelAttributes())
569+
.setAllAttributes(completeDatasetId.getOtelAttributes())
570570
.setAllAttributes(otelAttributesFromOptions(options))
571571
.startSpan();
572572
}

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7595,14 +7595,14 @@ public void testOpenTelemetryTracingDatasets() {
75957595
assertEquals(createMap.get(AttributeKey.stringKey("defaultCollation")), "null");
75967596

75977597
Map<AttributeKey<?>, Object> getMap = OTEL_ATTRIBUTES.get("JAVA_BQ_SDK_datasetGet");
7598-
assertEquals(getMap.get(AttributeKey.stringKey("datasetId")), billingModelDataset);
7598+
assertEquals(getMap.get(AttributeKey.stringKey("dataset")), billingModelDataset);
75997599

76007600
Map<AttributeKey<?>, Object> updateMap = OTEL_ATTRIBUTES.get("JAVA_BQ_SDK_datasetUpdate");
76017601
assertEquals(updateMap.get(AttributeKey.stringKey("description")), "Updated Description");
76027602
assertEquals(updateMap.get(AttributeKey.stringKey("ACCESS_POLICY_VERSION")), "2");
76037603

76047604
Map<AttributeKey<?>, Object> deleteMap = OTEL_ATTRIBUTES.get("JAVA_BQ_SDK_datasetDelete");
7605-
assertEquals(deleteMap.get(AttributeKey.stringKey("datasetId")), billingModelDataset);
7605+
assertEquals(deleteMap.get(AttributeKey.stringKey("dataset")), billingModelDataset);
76067606

76077607
// All should be children spans of parentSpan
76087608
assertEquals(

0 commit comments

Comments
 (0)