Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Commit 55316f8

Browse files
committed
change datasetId key to dataset
1 parent 66d79bf commit 55316f8

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,7 @@ && getOptions().getOpenTelemetryTracer() != null) {
567567
getOptions()
568568
.getOpenTelemetryTracer()
569569
.spanBuilder("JAVA_BQ_SDK_datasetGet")
570-
.setAllAttributes(datasetId.getOtelAttributes())
570+
.setAllAttributes(completeDatasetId.getOtelAttributes())
571571
.setAllAttributes(otelAttributesFromOptions(options))
572572
.startSpan();
573573
}

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7592,14 +7592,14 @@ public void testOpenTelemetryTracingDatasets() {
75927592
assertEquals(createMap.get(AttributeKey.stringKey("defaultCollation")), "null");
75937593

75947594
Map<AttributeKey<?>, Object> getMap = OTEL_ATTRIBUTES.get("JAVA_BQ_SDK_datasetGet");
7595-
assertEquals(getMap.get(AttributeKey.stringKey("datasetId")), billingModelDataset);
7595+
assertEquals(getMap.get(AttributeKey.stringKey("dataset")), billingModelDataset);
75967596

75977597
Map<AttributeKey<?>, Object> updateMap = OTEL_ATTRIBUTES.get("JAVA_BQ_SDK_datasetUpdate");
75987598
assertEquals(updateMap.get(AttributeKey.stringKey("description")), "Updated Description");
75997599
assertEquals(updateMap.get(AttributeKey.stringKey("ACCESS_POLICY_VERSION")), "2");
76007600

76017601
Map<AttributeKey<?>, Object> deleteMap = OTEL_ATTRIBUTES.get("JAVA_BQ_SDK_datasetDelete");
7602-
assertEquals(deleteMap.get(AttributeKey.stringKey("datasetId")), billingModelDataset);
7602+
assertEquals(deleteMap.get(AttributeKey.stringKey("dataset")), billingModelDataset);
76037603

76047604
// All should be children spans of parentSpan
76057605
assertEquals(

0 commit comments

Comments
 (0)