Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Commit b57a1f5

Browse files
committed
feat: Relax client-side validation for BigQuery entity IDs
Removes client-side `checkArgument` and `checkNotNull` validations from the constructors of `TableId`, `DatasetId`, `RoutineId`, `ModelId`, and `ConnectionProperty`. This change makes the client library more robust by preventing crashes when the server sends a response with unexpected null or empty values in these fields.
1 parent 4e09f6b commit b57a1f5

5 files changed

Lines changed: 2 additions & 9 deletions

File tree

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionProperty.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ public ConnectionProperty build() {
8282
}
8383

8484
private ConnectionProperty(Builder builder) {
85-
this.key = checkNotNull(builder.key, "Required key is null or empty");
86-
this.value = checkNotNull(builder.value, "Required value is null or empty");
85+
this.key = builder.key;
86+
this.value = builder.value;
8787
}
8888

8989
/** Return the key of property. */

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/DatasetId.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ public String getDataset() {
4343
}
4444

4545
private DatasetId(String project, String dataset) {
46-
checkArgument(!isNullOrEmpty(dataset), "Provided dataset is null or empty");
4746
this.project = project;
4847
this.dataset = dataset;
4948
}

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ModelId.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ public String getModel() {
6262
}
6363

6464
private ModelId(String project, String dataset, String model) {
65-
checkArgument(!isNullOrEmpty(dataset), "Provided dataset is null or empty");
66-
checkArgument(!isNullOrEmpty(model), "Provided model is null or empty");
6765
this.project = project;
6866
this.dataset = dataset;
6967
this.model = model;

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/RoutineId.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ public String getRoutine() {
6363
}
6464

6565
private RoutineId(String project, String dataset, String routine) {
66-
checkArgument(!isNullOrEmpty(dataset), "Provided dataset is null or empty");
67-
checkArgument(!isNullOrEmpty(routine), "Provided routine is null or empty");
6866
this.project = project;
6967
this.dataset = dataset;
7068
this.routine = routine;

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableId.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ public String getIAMResourceName() {
7171
}
7272

7373
private TableId(String project, String dataset, String table) {
74-
checkArgument(!isNullOrEmpty(dataset), "Provided dataset is null or empty");
75-
checkArgument(!isNullOrEmpty(table), "Provided table is null or empty");
7674
this.project = project;
7775
this.dataset = dataset;
7876
this.table = table;

0 commit comments

Comments
 (0)