Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Commit c98246f

Browse files
committed
fix: failing tests
1 parent 2a4ea57 commit c98246f

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcUrlUtility.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,7 @@ private static Map<String, String> parseUrlInternal(String url) {
710710
String.format("Wrong value or unknown setting: %s", safeRef));
711711
}
712712

713-
map.put(PROPERTY_NAME_MAP.get(key), CharEscapers.decodeUriPath(kv[1]));
713+
map.put(PROPERTY_NAME_MAP.get(key), CharEscapers.decodeUriPath(kv[1].replace("+", "%2B")));
714714
}
715715
return Collections.unmodifiableMap(map);
716716
}

google-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryJdbcOAuthUtilityTest.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,18 @@ public class BigQueryJdbcOAuthUtilityTest extends BigQueryJdbcBaseTest {
4949
+ USER_AUTH_PORT
5050
+ "&scope=https://www.googleapis.com/auth/bigquery&state=test_state&access_type=offline&prompt=consent&login_hint=test_user&include_granted_scopes=true";
5151

52+
@Test
53+
public void testParseOAuthPropsWithSpecialChars() {
54+
Map<String, String> result =
55+
BigQueryJdbcOAuthUtility.parseOAuthProperties(
56+
DataSource.fromUrl(
57+
"jdbc:bigquery://https://www.googleapis.com/bigquery/v2:443;"
58+
+ "ProjectId=MyProject;OAuthType=0;OAuthServiceAcctEmail=dummy@email.com;"
59+
+ "OAuthPvtKey=Key+With+Plus;"),
60+
null);
61+
assertEquals("Key+With+Plus", result.get("OAuthPvtKey"));
62+
}
63+
5264
@Test
5365
public void testParseOAuthPropsForAuthType0KeyfileOnly() {
5466
Map<String, String> result =

0 commit comments

Comments
 (0)