Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Commit dd4e58f

Browse files
committed
chore: Address PR feedback
1 parent cfc0b26 commit dd4e58f

2 files changed

Lines changed: 14 additions & 18 deletions

File tree

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryOptions.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,10 +230,10 @@ public void setThrowNotFound(boolean setThrowNotFound) {
230230
* Builder#setDataFormatOptions(DataFormatOptions)} to set the int64timestamp configuration
231231
* instead.
232232
*
233-
* <p>If useInt64Timestamps is set via DataFormatOptions, then that value in DataFormatOptions
234-
* will be used.
233+
* <p>If useInt64Timestamps is set via DataFormatOptions, then the value in DataFormatOptions will
234+
* be used. Otherwise, this value will be passed to DataFormatOptions.
235235
*
236-
* <p>{@code DataFormatOptions.newBuilder().setUseInt64Timestamp(...).build()}
236+
* <p>Alternative: {@code DataFormatOptions.newBuilder().setUseInt64Timestamp(...).build()}
237237
*/
238238
@ObsoleteApi("Use setDataFormatOptions(DataFormatOptions) instead")
239239
public void setUseInt64Timestamps(boolean useInt64Timestamps) {
@@ -255,6 +255,10 @@ public boolean getThrowNotFound() {
255255
* This getter is marked as Obsolete. Prefer {@link
256256
* DataFormatOptions.Builder#useInt64Timestamp(boolean)} to set the int64timestamp configuration
257257
* instead.
258+
*
259+
* <p>Warning: DataFormatOptions values have precedence. Use {@link
260+
* DataFormatOptions#useInt64Timestamp()} to get `useInt64Timestamp` value used by the BigQuery
261+
* client.
258262
*/
259263
@ObsoleteApi("Use getDataFormatOptions().isUseInt64Timestamp() instead")
260264
public boolean getUseInt64Timestamps() {

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/DataFormatOptions.java

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import com.google.auto.value.AutoValue;
1919
import java.io.Serializable;
20-
import javax.annotation.Nullable;
2120

2221
/**
2322
* Google BigQuery DataFormatOptions. Configures the output format for data types returned from
@@ -45,11 +44,12 @@ public String toString() {
4544

4645
public abstract boolean useInt64Timestamp();
4746

48-
@Nullable
4947
public abstract TimestampFormatOptions timestampFormatOptions();
5048

5149
public static Builder newBuilder() {
52-
return new AutoValue_DataFormatOptions.Builder().useInt64Timestamp(false);
50+
return new AutoValue_DataFormatOptions.Builder()
51+
.useInt64Timestamp(false)
52+
.timestampFormatOptions(TimestampFormatOptions.TIMESTAMP_OUTPUT_FORMAT_UNSPECIFIED);
5353
}
5454

5555
public abstract Builder toBuilder();
@@ -62,27 +62,19 @@ public abstract static class Builder {
6262

6363
abstract TimestampFormatOptions timestampFormatOptions();
6464

65-
abstract DataFormatOptions autoBuild();
66-
67-
public DataFormatOptions build() {
68-
if (timestampFormatOptions() == null) {
69-
timestampFormatOptions(TimestampFormatOptions.TIMESTAMP_OUTPUT_FORMAT_UNSPECIFIED);
70-
}
71-
return autoBuild();
72-
}
65+
public abstract DataFormatOptions build();
7366
}
7467

7568
com.google.api.services.bigquery.model.DataFormatOptions toPb() {
7669
com.google.api.services.bigquery.model.DataFormatOptions request =
7770
new com.google.api.services.bigquery.model.DataFormatOptions();
7871
request.setUseInt64Timestamp(useInt64Timestamp());
79-
if (timestampFormatOptions() != null) {
80-
request.setTimestampOutputFormat(timestampFormatOptions().toString());
81-
}
72+
request.setTimestampOutputFormat(timestampFormatOptions().toString());
8273
return request;
8374
}
8475

85-
DataFormatOptions fromPb(com.google.api.services.bigquery.model.DataFormatOptions request) {
76+
static DataFormatOptions fromPb(
77+
com.google.api.services.bigquery.model.DataFormatOptions request) {
8678
AutoValue_DataFormatOptions.Builder builder = new AutoValue_DataFormatOptions.Builder();
8779
if (request.getUseInt64Timestamp() != null) {
8880
builder.useInt64Timestamp(request.getUseInt64Timestamp());

0 commit comments

Comments
 (0)