Addressed comments

Author: sakthivelmanii

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerTypeConverter.java

@@ -28,6 +28,7 @@
 import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
+import java.util.function.Consumer;
 import java.util.function.Function;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
@@ -62,38 +63,38 @@ static <T> Value createUntypedStringValue(T value) {
         com.google.protobuf.Value.newBuilder().setStringValue(String.valueOf(value)).build());
   }
 
-  @SuppressWarnings("unchecked")
   static <T, U> Iterable<U> convertToTypedIterable(
       Function<T, U> func, T val, Iterator<?> iterator) {
     List<U> values = new ArrayList<>();
-    values.add(func.apply(val));
-    iterator.forEachRemaining(value -> values.add(func.apply((T) value)));
+    SpannerTypeConverter.processIterable(val, iterator, func, values::add);
     return values;
   }
 
   static <T> Iterable<T> convertToTypedIterable(T val, Iterator<?> iterator) {
     return convertToTypedIterable(v -> v, val, iterator);
   }
 
+  @SuppressWarnings("unchecked")
+  static <T, U> void processIterable(
+      T val, Iterator<?> iterator, Function<T, U> func, Consumer<U> consumer) {
+    consumer.accept(func.apply(val));
+    iterator.forEachRemaining(values -> consumer.accept(func.apply((T) values)));
+  }
+
   static Date convertLocalDateToSpannerDate(LocalDate date) {
     return Date.fromYearMonthDay(date.getYear(), date.getMonthValue(), date.getDayOfMonth());
   }
 
   static <T> Value createUntypedIterableValue(
       T value, Iterator<?> iterator, Function<T, String> func) {
+    ListValue.Builder listValueBuilder = ListValue.newBuilder();
+    SpannerTypeConverter.processIterable(
+        value,
+        iterator,
+        (val) -> com.google.protobuf.Value.newBuilder().setStringValue(func.apply(val)).build(),
+        listValueBuilder::addValues);
     return Value.untyped(
-        com.google.protobuf.Value.newBuilder()
-            .setListValue(
-                ListValue.newBuilder()
-                    .addAllValues(
-                        SpannerTypeConverter.convertToTypedIterable(
-                            (val) ->
-                                com.google.protobuf.Value.newBuilder()
-                                    .setStringValue(func.apply(val))
-                                    .build(),
-                            value,
-                            iterator)))
-            .build());
+        com.google.protobuf.Value.newBuilder().setListValue(listValueBuilder.build()).build());
   }
 
   static ZonedDateTime atUTC(LocalDateTime localDateTime) {

google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java

@@ -49,7 +49,6 @@
 import java.math.BigDecimal;
 import java.math.BigInteger;
 import java.nio.charset.StandardCharsets;
-import java.time.Instant;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.time.OffsetDateTime;
@@ -2580,13 +2579,6 @@ public void testToValue() {
     assertEquals(Type.date(), value.getType());
     assertEquals(date, value.getDate());
 
-    java.util.Date utilDate =
-        java.util.Date.from(
-            Instant.from(LocalDateTime.of(2018, 2, 26, 11, 30).toInstant(ZoneOffset.UTC)));
-    value = Value.toValue(utilDate);
-    assertEquals(Type.date(), value.getType());
-    assertEquals(date, value.getDate());
-
     LocalDate localDate = LocalDate.of(2018, 2, 26);
     value = Value.toValue(localDate);
     assertEquals(Type.date(), value.getType());
@@ -2768,16 +2760,6 @@ public void testToValueIterable() {
     assertEquals(Type.array(Type.date()), value.getType());
     assertEquals(dates, value.getDateArray());
 
-    List<java.util.Date> javaDates =
-        Arrays.asList(
-            java.util.Date.from(
-                ZonedDateTime.of(2024, 8, 23, 11, 12, 13, 10, ZoneId.of("UTC")).toInstant()),
-            java.util.Date.from(
-                ZonedDateTime.of(2024, 12, 27, 11, 12, 13, 10, ZoneId.of("UTC")).toInstant()));
-    value = Value.toValue(javaDates);
-    assertEquals(Type.array(Type.date()), value.getType());
-    assertEquals(dates, value.getDateArray());
-
     List<LocalDate> localDates =
         Arrays.asList(LocalDate.of(2024, 8, 23), LocalDate.of(2024, 12, 27));
     value = Value.toValue(localDates);