Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

Commit 4339dd3

Browse files
committed
Fix more merge issues
1 parent 0f0afeb commit 4339dd3

4 files changed

Lines changed: 7 additions & 37 deletions

File tree

.github/workflows/unittest.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ jobs:
4545
- "3.12"
4646
- "3.13"
4747
- "3.14"
48-
option:
49-
- ""
50-
- "_protobuf_4x"
5148
steps:
5249
- name: Checkout
5350
uses: actions/checkout@v4
@@ -62,14 +59,14 @@ jobs:
6259
python -m pip install nox
6360
- name: Run unit tests
6461
env:
65-
COVERAGE_FILE: .coverage${{ matrix.option }}-${{matrix.python }}
62+
COVERAGE_FILE: .coverage-${{matrix.python }}
6663
run: |
67-
nox -s unit${{ matrix.option }}-${{ matrix.python }}
64+
nox -s unit-${{ matrix.python }}
6865
- name: Upload coverage results
6966
uses: actions/upload-artifact@v4
7067
with:
71-
name: coverage-artifact-${{ matrix.option }}-${{ matrix.python }}
72-
path: .coverage${{ matrix.option }}-${{ matrix.python }}
68+
name: coverage-artifact-${{ matrix.python }}
69+
path: .coverage-${{ matrix.python }}
7370
include-hidden-files: true
7471

7572
report-coverage:

google/api_core/_python_package_support.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
_PACKAGE_DEPENDENCY_WARNINGS = [
3838
DependencyConstraint(
3939
"google.protobuf",
40-
minimum_fully_supported_version="5.0.0",
40+
minimum_fully_supported_version="4.25.8",
4141
recommended_version="6.x",
4242
)
4343
]

noxfile.py

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -218,12 +218,12 @@ def unit(session, install_grpc, install_async_rest, python_versions=None, proto4
218218

219219
"""Run the unit test suite."""
220220

221-
# TODO: Remove this code and the corresponding parameter once we stop support for protobuf 4.x.
221+
# TODO: Remove this code and the corresponding parameters once we stop support for protobuf 4.x.
222222
if python_versions and session.python not in python_versions:
223223
session.log(f"Skipping session for Python {session.python}")
224224
session.skip()
225225

226-
# TODO: Remove this code and the corresponding parameter once we stop support for protobuf 4.x.
226+
# TODO: Remove this code and the corresponding parameters once we stop support for protobuf 4.x.
227227
if proto4:
228228
# Pin protobuf to a 4.x version to ensure coverage for the legacy code path.
229229
session.install("protobuf>=4.25.8,<5.0.0")
@@ -235,18 +235,6 @@ def unit(session, install_grpc, install_async_rest, python_versions=None, proto4
235235
)
236236

237237

238-
# TODO: Remove once we stop support for protobuf 4.x.
239-
@nox.session(python=PYTHON_VERSIONS)
240-
def unit_protobuf_4x(session):
241-
"""Run the unit test suite with protobuf 4.x."""
242-
if session.python not in ["3.9", "3.10", "3.11"]:
243-
session.log(f"Skipping session for Python {session.python}")
244-
session.skip()
245-
# Pin protobuf to a 4.x version to ensure coverage for the legacy code path.
246-
session.install("protobuf>=4.25.8,<5.0.0")
247-
default(session, install_grpc=True)
248-
249-
250238
@nox.session(python=DEFAULT_PYTHON_VERSION)
251239
def prerelease_deps(session):
252240
"""Run the unit test suite."""
@@ -261,12 +249,6 @@ def lint_setup_py(session):
261249
session.run("python", "setup.py", "check", "--restructuredtext", "--strict")
262250

263251

264-
@nox.session(python=DEFAULT_PYTHON_VERSION)
265-
def pytype(session):
266-
"""Run type-checking."""
267-
session.install(".[grpc]", "pytype")
268-
session.run("pytype")
269-
270252
@nox.session(python=DEFAULT_PYTHON_VERSION)
271253
def mypy(session):
272254
"""Run type-checking."""

setup.cfg

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +0,0 @@
1-
[pytype]
2-
python_version = 3.9
3-
inputs =
4-
google/
5-
exclude =
6-
tests/
7-
output = .pytype/
8-
# Workaround for https://github.com/google/pytype/issues/150
9-
disable = pyi-error

0 commit comments

Comments
 (0)