Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

Commit 6493e33

Browse files
committed
refactor: add _PACKAGE_DEPENDENCY_WARNINGS
1 parent d13feb1 commit 6493e33

1 file changed

Lines changed: 24 additions & 4 deletions

File tree

google/api_core/_python_package_support.py

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,24 @@
2727

2828
from packaging.version import parse as parse_version
2929

30-
DependencyVersion = namedtuple("DependencyVersion", ["version", "version_string"])
30+
# Here we list all the packages for which we want to issue warnings
31+
# about deprecated and unsupported versions.
32+
_DependencyConstraint = namedtuple(
33+
"_DependencyConstraint",
34+
["package_name", "minimum_fully_supported_version", "recommended_version"],
35+
)
36+
_PACKAGE_DEPENDENCY_WARNINGS = [
37+
_DependencyConstraint(
38+
"google.protobuf",
39+
minimum_fully_supported_version="4.25.8",
40+
recommended_version="6.x",
41+
)
42+
]
43+
3144

45+
DependencyVersion = namedtuple("DependencyVersion", ["version", "version_string"])
46+
# Version string we provide in a DependencyVersion when we can't determine the version of a
47+
# package.
3248
UNKNOWN_VERSION_STRING = "--"
3349

3450

@@ -177,6 +193,10 @@ def check_dependency_versions(consumer_import_package: str):
177193
dependencies we're checking.
178194
179195
"""
180-
warn_deprecation_for_versions_less_than(
181-
consumer_import_package, "google.protobuf", "4.25.8", recommended_version="6.x"
182-
)
196+
for package_info in _PACKAGE_DEPENDENCY_WARNINGS:
197+
warn_deprecation_for_versions_less_than(
198+
consumer_import_package,
199+
package_info.package_name,
200+
package_info.minimum_fully_supported_version,
201+
recommended_version=package_info.recommended_version,
202+
)

0 commit comments

Comments
 (0)