This repository was archived by the owner on Feb 23, 2026. It is now read-only.
File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change 1616import logging
1717import queue
1818import threading
19+ import time
1920
2021try :
2122 from unittest import mock
@@ -894,3 +895,26 @@ def close_side_effect():
894895
895896 # calling stop twice should not result in an error.
896897 consumer .stop ()
898+
899+ def test_stop_error_logs (self , caplog ):
900+ """
901+ Closing the client should result in no internal error logs
902+
903+ https://github.com/googleapis/python-api-core/issues/788
904+ """
905+ caplog .set_level (logging .DEBUG )
906+ bidi_rpc = mock .create_autospec (bidi .BidiRpc , instance = True )
907+ bidi_rpc .is_active = True
908+ on_response = mock .Mock (spec = ["__call__" ])
909+
910+ consumer = bidi .BackgroundConsumer (bidi_rpc , on_response )
911+
912+ consumer .start ()
913+ consumer .stop ()
914+ # let the background thread run for a while before exiting
915+ time .sleep (0.1 )
916+ bidi_rpc .is_active = False
917+ # running thread should not result in error logs
918+ error_logs = [r .message for r in caplog .records if r .levelname == "ERROR" ]
919+ assert not error_logs , f"Found unexpected ERROR logs: { error_logs } "
920+ bidi_rpc .is_active = False
You can’t perform that action at this time.
0 commit comments