Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Commit 409385c

Browse files
test: add 3.9 unit tests (#59)
1 parent 4c62f9c commit 409385c

4 files changed

Lines changed: 26 additions & 19 deletions

File tree

google/cloud/billing/budgets_v1beta1/proto/budget_model.proto

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -187,13 +187,17 @@ message Filter {
187187
// Only zero or one project can be specified currently.
188188
repeated string projects = 1 [(google.api.field_behavior) = OPTIONAL];
189189

190-
// Optional. A list of credit types to be subtracted from gross cost to
191-
// determine the spend for threshold calculations if and only if
192-
// credit_types_treatment is INCLUDE_SPECIFIED_CREDITS. If
193-
// credit_types_treatment is not INCLUDE_SPECIFIED_CREDITS, this field must be
194-
// empty. See credits.type at
195-
// https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#data-schema
196-
// for a list of acceptable credit type values in this field.
190+
// Optional. If
191+
// [Filter.credit_types_treatment][google.cloud.billing.budgets.v1beta1.Filter.credit_types_treatment]
192+
// is INCLUDE_SPECIFIED_CREDITS, this is a list of credit types to be
193+
// subtracted from gross cost to determine the spend for threshold
194+
// calculations.
195+
//
196+
// If
197+
// [Filter.credit_types_treatment][google.cloud.billing.budgets.v1beta1.Filter.credit_types_treatment]
198+
// is **not** INCLUDE_SPECIFIED_CREDITS, this field must be empty. See [a list
199+
// of acceptable credit type
200+
// values](https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#credits-type).
197201
repeated string credit_types = 7 [(google.api.field_behavior) = OPTIONAL];
198202

199203
// Optional. If not set, default behavior is `INCLUDE_ALL_CREDITS`.

google/cloud/billing/budgets_v1beta1/types/budget_model.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -217,14 +217,17 @@ class Filter(proto.Message):
217217
account, regardless of which project the usage occurred on.
218218
Only zero or one project can be specified currently.
219219
credit_types (Sequence[str]):
220-
Optional. A list of credit types to be subtracted from gross
221-
cost to determine the spend for threshold calculations if
222-
and only if credit_types_treatment is
223-
INCLUDE_SPECIFIED_CREDITS. If credit_types_treatment is not
224-
INCLUDE_SPECIFIED_CREDITS, this field must be empty. See
225-
credits.type at
226-
https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#data-schema
227-
for a list of acceptable credit type values in this field.
220+
Optional. If
221+
[Filter.credit_types_treatment][google.cloud.billing.budgets.v1beta1.Filter.credit_types_treatment]
222+
is INCLUDE_SPECIFIED_CREDITS, this is a list of credit types
223+
to be subtracted from gross cost to determine the spend for
224+
threshold calculations.
225+
226+
If
227+
[Filter.credit_types_treatment][google.cloud.billing.budgets.v1beta1.Filter.credit_types_treatment]
228+
is **not** INCLUDE_SPECIFIED_CREDITS, this field must be
229+
empty. See `a list of acceptable credit type
230+
values <https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#credits-type>`__.
228231
credit_types_treatment (~.budget_model.Filter.CreditTypesTreatment):
229232
Optional. If not set, default behavior is
230233
``INCLUDE_ALL_CREDITS``.

noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
DEFAULT_PYTHON_VERSION = "3.8"
3030
SYSTEM_TEST_PYTHON_VERSIONS = ["3.8"]
31-
UNIT_TEST_PYTHON_VERSIONS = ["3.6", "3.7", "3.8"]
31+
UNIT_TEST_PYTHON_VERSIONS = ["3.6", "3.7", "3.8", "3.9"]
3232

3333

3434
@nox.session(python=DEFAULT_PYTHON_VERSION)

synth.metadata

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/python-billingbudgets.git",
7-
"sha": "b6db1db2055d122614647e492cd3dcd444ebb7e7"
7+
"sha": "4c62f9c89128f70f84ef886345feeb7cb45b4888"
88
}
99
},
1010
{
1111
"git": {
1212
"name": "googleapis",
1313
"remote": "https://github.com/googleapis/googleapis.git",
14-
"sha": "5359df5297982d551ac5dcc20c8a29de04c70090",
15-
"internalRef": "341146950"
14+
"sha": "6c0f55f33f882cf97fd3135e93b144ad9c94ebab",
15+
"internalRef": "341478628"
1616
}
1717
},
1818
{

0 commit comments

Comments
 (0)