Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Commit 04dc582

Browse files
committed
review comments
1 parent 44c584b commit 04dc582

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

google/cloud/spanner_v1/client.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,7 @@ class Client(ClientWithProject):
164164
165165
:type default_transaction_options: :class:`~google.cloud.spanner_v1.TransactionOptions`
166166
or :class:`dict`
167-
:param default_transaction_options: (Optional) Client options used to set the default_transaction_options
168-
used for all Read Write Transactions.
167+
:param default_transaction_options: (Optional) Default options to use for all read/write transactions.
169168
170169
:raises: :class:`ValueError <exceptions.ValueError>` if both ``read_only``
171170
and ``admin`` are :data:`True`
@@ -348,7 +347,7 @@ def default_transaction_options(self):
348347
:rtype:
349348
:class:`~google.cloud.spanner_v1.TransactionOptions`
350349
or :class:`dict`
351-
:returns: The default_transaction_options for the client.
350+
:returns: The default transaction options that are used by this client for all read/write transactions.
352351
"""
353352
return self._default_transaction_options
354353

@@ -503,7 +502,6 @@ def default_transaction_options(self, default_transaction_options):
503502
"""Sets default_transaction_options for the client
504503
:type default_transaction_options: :class:`~google.cloud.spanner_v1.TransactionOptions`
505504
or :class:`dict`
506-
:param default_transaction_options: Client options used to set the default_transaction_options
507-
used for all Read Write Transactions.
505+
:param default_transaction_options: Default options to use for all read/write transactions.
508506
"""
509507
self._default_transaction_options = default_transaction_options

google/cloud/spanner_v1/database.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -815,7 +815,7 @@ def batch(
815815
:type isolation_level:
816816
:class:`google.cloud.spanner_v1.types.TransactionOptions.IsolationLevel`
817817
:param isolation_level:
818-
(Optional) Sets isolation level for the transaction and overrides the isolation level set at the client.
818+
(Optional) Sets the isolation level for this transaction. This overrides any default isolation level set for the client.
819819
820820
:rtype: :class:`~google.cloud.spanner_v1.database.BatchCheckout`
821821
:returns: new wrapper
@@ -1237,6 +1237,7 @@ def __exit__(self, exc_type, exc_val, exc_tb):
12371237
max_commit_delay=self._max_commit_delay,
12381238
exclude_txn_from_change_streams=self._exclude_txn_from_change_streams,
12391239
isolation_level=self._isolation_level,
1240+
**self._kw,
12401241
)
12411242
finally:
12421243
if self._database.log_commit_stats and self._batch.commit_stats:

0 commit comments

Comments
 (0)