chore: add depreciation warning for generation_number (#1740)

Add a warning that generation_number will be deprecated in the next
major release.

Author: Pulkit0110

google/cloud/storage/asyncio/async_multi_range_downloader.py

@@ -208,6 +208,10 @@ def __init__(
                     "Cannot set both 'generation' and 'generation_number'. "
                     "Use 'generation' for new code."
                 )
+            logger.warning(
+                "'generation_number' is deprecated and will be removed in a future "
+                "major release. Please use 'generation' instead."
+            )
             generation = kwargs.pop("generation_number")
 
         raise_if_no_fast_crc32c()

tests/system/test_zonal.py

@@ -601,56 +601,3 @@ async def _run():
         gc.collect()
 
     event_loop.run_until_complete(_run())
-
-def test_get_object_after_appendable_write(
-    grpc_clients,
-    grpc_client_direct,
-    event_loop,
-    storage_client,
-    blobs_to_delete,
-):
-    """Test getting object metadata after writing with AsyncAppendableObjectWriter.
-
-    This test:
-    1. Creates a test object using AsyncAppendableObjectWriter
-    2. Appends content to the object (without finalizing)
-    3. Closes the write stream
-    4. Fetches the object metadata using AsyncGrpcClient.get_object()
-    5. Verifies the object size matches the written data
-    """
-
-    async def _run():
-        grpc_client = grpc_client_direct
-        object_name = f"test-get-object-{uuid.uuid4().hex}"
-        test_data = b"Some test data bytes."
-        expected_size = len(test_data)
-
-        writer = AsyncAppendableObjectWriter(
-            grpc_client,
-            _ZONAL_BUCKET,
-            object_name,
-        )
-
-        await writer.open()
-        await writer.append(test_data)
-        await writer.close(finalize_on_close=False)
-
-        obj = await grpc_client.get_object(
-            bucket_name=_ZONAL_BUCKET,
-            object_name=object_name,
-        )
-
-        # Assert
-        assert obj is not None
-        assert obj.name == object_name
-        assert obj.bucket == f"projects/_/buckets/{_ZONAL_BUCKET}"
-        assert obj.size == expected_size, (
-            f"Expected object size {expected_size}, got {obj.size}"
-        )
-
-        # Cleanup
-        blobs_to_delete.append(storage_client.bucket(_ZONAL_BUCKET).blob(object_name))
-        del writer
-        gc.collect()
-
-    event_loop.run_until_complete(_run())

tests/unit/asyncio/test_async_multi_range_downloader.py

@@ -407,7 +407,7 @@ async def close_side_effect():
     )
     @pytest.mark.asyncio
     async def test_create_mrd_with_generation_number(
-        self, mock_cls_async_read_object_stream
+        self, mock_cls_async_read_object_stream, caplog
     ):
         # Arrange
         mock_client = mock.MagicMock()
@@ -430,6 +430,7 @@ async def test_create_mrd_with_generation_number(
 
         # Assert
         assert mrd.generation == _TEST_GENERATION_NUMBER
+        assert "'generation_number' is deprecated" in caplog.text
 
     @pytest.mark.asyncio
     async def test_create_mrd_with_both_generation_and_generation_number(self):