Skip to content

Commit 09d1539

Browse files
committed
test: adjust goldens for pubsub
1 parent e9fe905 commit 09d1539

7 files changed

Lines changed: 21 additions & 3 deletions

File tree

gax-java/dependencies.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ maven.com_google_api_grpc_grpc_google_common_protos=com.google.api.grpc:grpc-goo
4040
maven.com_google_auth_google_auth_library_oauth2_http=com.google.auth:google-auth-library-oauth2-http:1.42.1
4141
maven.com_google_auth_google_auth_library_credentials=com.google.auth:google-auth-library-credentials:1.42.1
4242
maven.io_opentelemetry_opentelemetry_api=io.opentelemetry:opentelemetry-api:1.47.0
43+
maven.io_opentelemetry_opentelemetry_context=io.opentelemetry:opentelemetry-context:1.47.0
4344
maven.io_opencensus_opencensus_api=io.opencensus:opencensus-api:0.31.1
4445
maven.io_opencensus_opencensus_contrib_grpc_metrics=io.opencensus:opencensus-contrib-grpc-metrics:0.31.1
4546
maven.io_opencensus_opencensus_contrib_http_util=io.opencensus:opencensus-contrib-http-util:0.31.1

gax-java/gax/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ _COMPILE_DEPS = [
1919
"@com_google_errorprone_error_prone_annotations//jar",
2020
"@com_google_guava_guava//jar",
2121
"@io_opentelemetry_opentelemetry_api//jar",
22+
"@io_opentelemetry_opentelemetry_context//jar",
2223
"@io_opencensus_opencensus_api//jar",
2324
"@io_opencensus_opencensus_contrib_http_util//jar",
2425
"@io_grpc_grpc_java//context:context",

rules_java_gapic/java_gapic.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,6 @@ def _java_gapic_srcjar(
197197
**kwargs):
198198
file_args_dict = {}
199199

200-
if artifact_name:
201-
opt_args.append("artifact-name=%s" % artifact_name)
202-
203200
if grpc_service_config:
204201
file_args_dict[grpc_service_config] = "grpc-service-config"
205202
elif not transport or transport == "grpc":
@@ -215,6 +212,9 @@ def _java_gapic_srcjar(
215212

216213
opt_args = []
217214

215+
if artifact_name:
216+
opt_args.append("artifact-name=%s" % artifact_name)
217+
218218
if transport:
219219
opt_args.append("transport=%s" % transport)
220220

test/integration/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ java_gapic_library(
244244
grpc_service_config = "@com_google_googleapis//google/pubsub/v1:pubsub_grpc_service_config.json",
245245
# For the IAM mixin.
246246
service_yaml = "pubsub_v1.yaml",
247+
artifact_name = "com.google.cloud:google-cloud-pubsub",
247248
test_deps = [
248249
"@com_google_googleapis//google/pubsub/v1:pubsub_java_grpc",
249250
"@com_google_googleapis//google/iam/v1:iam_java_grpc",

test/integration/goldens/pubsub/src/com/google/cloud/pubsub/v1/stub/PublisherStubSettings.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -485,6 +485,11 @@ public String getServiceName() {
485485
return "pubsub";
486486
}
487487

488+
@Override
489+
protected String getArtifactName() {
490+
return "com.google.cloud:google-cloud-pubsub";
491+
}
492+
488493
/** Returns a builder for the default ExecutorProvider for this service. */
489494
public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuilder() {
490495
return InstantiatingExecutorProvider.newBuilder();

test/integration/goldens/pubsub/src/com/google/cloud/pubsub/v1/stub/SchemaServiceStubSettings.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,11 @@ public String getServiceName() {
346346
return "pubsub";
347347
}
348348

349+
@Override
350+
protected String getArtifactName() {
351+
return "com.google.cloud:google-cloud-pubsub";
352+
}
353+
349354
/** Returns a builder for the default ExecutorProvider for this service. */
350355
public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuilder() {
351356
return InstantiatingExecutorProvider.newBuilder();

test/integration/goldens/pubsub/src/com/google/cloud/pubsub/v1/stub/SubscriberStubSettings.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,11 @@ public String getServiceName() {
392392
return "pubsub";
393393
}
394394

395+
@Override
396+
protected String getArtifactName() {
397+
return "com.google.cloud:google-cloud-pubsub";
398+
}
399+
395400
/** Returns a builder for the default ExecutorProvider for this service. */
396401
public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuilder() {
397402
return InstantiatingExecutorProvider.newBuilder();

0 commit comments

Comments
 (0)