Skip to content

Commit 0c3bd22

Browse files
committed
chore: use server address instead of endpoint context
1 parent 0f5e9b5 commit 0c3bd22

4 files changed

Lines changed: 8 additions & 13 deletions

File tree

gax-java/gax/src/main/java/com/google/api/gax/rpc/ClientContext.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,9 @@ public static ClientContext create(StubSettings settings) throws IOException {
271271
backgroundResources.add(watchdog);
272272
}
273273
ApiTracerContext apiTracerContext =
274-
ApiTracerContext.newBuilder().setEndpointContext(endpointContext).build();
274+
ApiTracerContext.newBuilder()
275+
.setServerAddress(endpointContext.resolvedServerAddress())
276+
.build();
275277
ApiTracerFactory apiTracerFactory = settings.getTracerFactory().withContext(apiTracerContext);
276278

277279
return newBuilder()

gax-java/gax/src/main/java/com/google/api/gax/tracing/ApiTracerContext.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
package com.google.api.gax.tracing;
3232

3333
import com.google.api.core.InternalApi;
34-
import com.google.api.gax.rpc.EndpointContext;
3534
import com.google.auto.value.AutoValue;
3635
import javax.annotation.Nullable;
3736

@@ -46,15 +45,15 @@
4645
public abstract class ApiTracerContext {
4746

4847
@Nullable
49-
public abstract EndpointContext getEndpointContext();
48+
public abstract String getServerAddress();
5049

5150
public static Builder newBuilder() {
5251
return new AutoValue_ApiTracerContext.Builder();
5352
}
5453

5554
@AutoValue.Builder
5655
public abstract static class Builder {
57-
public abstract Builder setEndpointContext(EndpointContext endpointContext);
56+
public abstract Builder setServerAddress(String serverAddress);
5857

5958
public abstract ApiTracerContext build();
6059
}

gax-java/gax/src/main/java/com/google/api/gax/tracing/TracingTracerFactory.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,8 @@ public ApiTracer newTracer(ApiTracer parent, SpanName spanName, OperationType op
9797
@Override
9898
public ApiTracerFactory withContext(ApiTracerContext context) {
9999
Map<String, String> newAttemptAttributes = new HashMap<>(this.attemptAttributes);
100-
if (context.getEndpointContext() != null) {
101-
newAttemptAttributes.put(
102-
TracingTracer.SERVER_ADDRESS_ATTRIBUTE,
103-
context.getEndpointContext().resolvedServerAddress());
100+
if (context.getServerAddress() != null) {
101+
newAttemptAttributes.put(TracingTracer.SERVER_ADDRESS_ATTRIBUTE, context.getServerAddress());
104102
}
105103
return new TracingTracerFactory(tracingRecorder, operationAttributes, newAttemptAttributes);
106104
}

gax-java/gax/src/test/java/com/google/api/gax/tracing/TracingTracerFactoryTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import static org.mockito.Mockito.verify;
4040
import static org.mockito.Mockito.when;
4141

42-
import com.google.api.gax.rpc.EndpointContext;
4342
import com.google.common.collect.ImmutableMap;
4443
import java.util.Map;
4544
import org.junit.jupiter.api.Test;
@@ -89,11 +88,8 @@ void testWithContext_addsInferredAttributes() {
8988
TracingRecorder.GaxSpan operationHandle = mock(TracingRecorder.GaxSpan.class);
9089
when(recorder.createSpan(anyString(), anyMap())).thenReturn(operationHandle);
9190

92-
EndpointContext endpointContext = mock(EndpointContext.class);
93-
when(endpointContext.resolvedServerAddress()).thenReturn("example.com");
94-
9591
ApiTracerContext context =
96-
ApiTracerContext.newBuilder().setEndpointContext(endpointContext).build();
92+
ApiTracerContext.newBuilder().setServerAddress("example.com").build();
9793

9894
TracingTracerFactory factory = new TracingTracerFactory(recorder);
9995
ApiTracerFactory factoryWithContext = factory.withContext(context);

0 commit comments

Comments
 (0)