fix: remove unnecessary overload

Author: diegomarquezp

gax-java/gax/src/main/java/com/google/api/gax/tracing/ApiTracerFactory.java

@@ -62,27 +62,15 @@ enum OperationType {
    */
   ApiTracer newTracer(ApiTracer parent, SpanName spanName, OperationType operationType);
 
-  /**
-   * Create a new {@link ApiTracer} that will be a child of the current context.
-   *
-   * @param parent the parent of this tracer
-   * @param tracerContext the method-definition-specific tracer context
-   * @param operationType the type of operation that the tracer will trace
-   */
-  default ApiTracer newTracer(
-      ApiTracer parent, ApiTracerContext tracerContext, OperationType operationType) {
-    SpanName spanName = SpanName.of(tracerContext);
-    return newTracer(parent, spanName, operationType);
-  }
-
   /**
    * Create a new {@link ApiTracer} that will be a child of the current context.
    *
    * @param parent the parent of this tracer
    * @param tracerContext the method-definition-specific tracer context
    */
   default ApiTracer newTracer(ApiTracer parent, ApiTracerContext tracerContext) {
-    return newTracer(parent, tracerContext, tracerContext.operationType());
+    SpanName spanName = SpanName.of(tracerContext);
+    return newTracer(parent, spanName, tracerContext.operationType());
   }
 
   /**

gax-java/gax/src/main/java/com/google/api/gax/tracing/SpanTracerFactory.java

@@ -77,7 +77,7 @@ public ApiTracer newTracer(ApiTracer parent, SpanName spanName, OperationType op
 
   @Override
   public ApiTracer newTracer(
-      ApiTracer parent, ApiTracerContext apiTracerContext, OperationType operationType) {
+      ApiTracer parent, ApiTracerContext apiTracerContext) {
     ApiTracerContext context = this.apiTracerContext.merge(apiTracerContext);
 
     String attemptSpanName;
@@ -90,8 +90,7 @@ public ApiTracer newTracer(
       attemptSpanName = context.fullMethodName() + "/attempt";
     }
 
-    SpanTracer spanTracer = new SpanTracer(traceManager, context, attemptSpanName);
-    return spanTracer;
+    return new SpanTracer(traceManager, context, attemptSpanName);
   }
 
   @Override

gax-java/gax/src/test/java/com/google/api/gax/tracing/SpanTracerFactoryTest.java

@@ -72,7 +72,7 @@ void testNewTracer_createsSpanTracer(boolean useContext) {
               .setTransport(Transport.GRPC)
               .setLibraryMetadata(LibraryMetadata.empty())
               .build();
-      tracer = factory.newTracer(null, context, OperationType.Unary);
+      tracer = factory.newTracer(null, context);
     } else {
       tracer = factory.newTracer(null, SpanName.of("service", "method"), OperationType.Unary);
     }
@@ -97,7 +97,7 @@ void testNewTracer_addsAttributes(boolean useContext) {
               .setTransport(Transport.GRPC)
               .setLibraryMetadata(LibraryMetadata.empty())
               .build();
-      tracer = factory.newTracer(null, context, OperationType.Unary);
+      tracer = factory.newTracer(null, context);
     } else {
       tracer = factory.newTracer(null, SpanName.of("service", "method"), OperationType.Unary);
     }
@@ -131,7 +131,7 @@ void testWithContext_addsInferredAttributes(boolean useContext) {
               .setTransport(Transport.GRPC)
               .setLibraryMetadata(LibraryMetadata.empty())
               .build();
-      tracer = factoryWithContext.newTracer(null, callContext, OperationType.Unary);
+      tracer = factoryWithContext.newTracer(null, callContext);
     } else {
       tracer =
           factoryWithContext.newTracer(null, SpanName.of("service", "method"), OperationType.Unary);
@@ -163,7 +163,7 @@ void testWithContext_noEndpointContext_doesNotAddServerAddressAttribute(boolean
               .setTransport(Transport.GRPC)
               .setLibraryMetadata(LibraryMetadata.empty())
               .build();
-      tracer = factoryWithContext.newTracer(null, callContext, OperationType.Unary);
+      tracer = factoryWithContext.newTracer(null, callContext);
     } else {
       tracer =
           factoryWithContext.newTracer(null, SpanName.of("service", "method"), OperationType.Unary);
@@ -189,7 +189,7 @@ void testNewTracer_withContext_grpc_usesFullMethodName() {
             .build();
 
     SpanTracerFactory factory = new SpanTracerFactory(traceManager);
-    ApiTracer tracer = factory.newTracer(null, context, OperationType.Unary);
+    ApiTracer tracer = factory.newTracer(null, context);
 
     tracer.attemptStarted(null, 1);
 
@@ -206,7 +206,7 @@ void testNewTracer_withContext_http_usesPlaceholder() {
             .build();
 
     SpanTracerFactory factory = new SpanTracerFactory(traceManager);
-    ApiTracer tracer = factory.newTracer(null, context, OperationType.Unary);
+    ApiTracer tracer = factory.newTracer(null, context);
 
     tracer.attemptStarted(null, 1);
 
@@ -240,7 +240,7 @@ void testNewTracer_mergesFactoryContext() {
             .setLibraryMetadata(LibraryMetadata.empty())
             .build();
 
-    ApiTracer tracer = factory.newTracer(null, callContext, OperationType.Unary);
+    ApiTracer tracer = factory.newTracer(null, callContext);
     tracer.attemptStarted(null, 1);
 
     ArgumentCaptor<Map<String, Object>> attributesCaptor = ArgumentCaptor.forClass(Map.class);