fix: Rename resource name to resource id.

Author: blakeli0

gax-java/gax/src/main/java/com/google/api/gax/rpc/ResourceNameExtractor.java

@@ -30,10 +30,13 @@
 package com.google.api.gax.rpc;
 
 import com.google.api.core.InternalApi;
+import com.google.api.gax.tracing.ObservabilityAttributes;
 
 /**
- * A client resource name extractor takes a {@code request} message and extracts the destination
- * resource name from it. This value is used primarily for tracing and observability.
+ * A resource name extractor takes a request message and extracts the resource name from it. This
+ * value is used primarily for tracing. It is added to spans as an attribute, labeled as
+ * gcp.resource.destination.id (See {@link
+ * ObservabilityAttributes#DESTINATION_RESOURCE_ID_ATTRIBUTE}).
  *
  * <p>Implementations of this interface are expected to be autogenerated.
  *
@@ -42,10 +45,10 @@
 @InternalApi("For use by transport-specific implementations")
 public interface ResourceNameExtractor<RequestT> {
   /**
-   * Extracts the destination resource name from the {@code request}.
+   * Extracts the resource name from the {@code request}.
    *
    * @param request request message
-   * @return the destination resource name extracted from the request
+   * @return the resource name extracted from the request
    */
   String extract(RequestT request);
 }

gax-java/gax/src/main/java/com/google/api/gax/tracing/ApiTracerContext.java

@@ -164,7 +164,7 @@ String rpcSystemName() {
   @Nullable
   public abstract String urlDomain();
 
-  /** The destination resource name of the request (e.g. projects/p/locations/l/topics/t). */
+  /** The destination resource id of the request (e.g. projects/p/locations/l/topics/t). */
   @Nullable
   public abstract String destinationResourceId();
 

gax-java/gax/src/main/java/com/google/api/gax/tracing/TracedUnaryCallable.java

@@ -112,7 +112,6 @@ public ApiFuture<ResponseT> futureCall(RequestT request, ApiCallContext context)
   @VisibleForTesting
   ApiTracerContext extractResourceNameToApiTracerContext(RequestT request) {
     ApiTracerContext finalContext = apiTracerContext;
-    // Extract the resource name early
     String resourceName =
         resourceNameExtractor != null ? resourceNameExtractor.extract(request) : null;
     if (!Strings.isNullOrEmpty(resourceName)) {