fix: make Version and its variable package private

Author: diegomarquezp

gapic-generator-java/src/main/java/com/google/api/generator/engine/ast/ClassDefinition.java

@@ -203,9 +203,6 @@ public ClassDefinition build() {
                 expr instanceof AssignmentExpr,
                 "Class expression statement must be assignment or variable declaration");
             VariableExpr variableExpr = ((AssignmentExpr) expr).variableExpr();
-            Preconditions.checkState(
-                !variableExpr.scope().equals(ScopeNode.LOCAL),
-                "Class variable in assignment statement cannot have a local scope");
           }
         }
       }

gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/LibraryVersionClassComposer.java

@@ -59,7 +59,7 @@ public GapicClass generate(GapicContext context, Service service) {
             .setVariableExpr(
                 versionVarExpr.toBuilder()
                     .setIsDecl(true)
-                    .setScope(ScopeNode.PUBLIC)
+                    .setScope(ScopeNode.LOCAL)
                     .setIsStatic(true)
                     .setIsFinal(true)
                     .build())

gapic-generator-java/src/test/java/com/google/api/generator/engine/ast/ClassDefinitionTest.java

@@ -293,31 +293,6 @@ void invalidClassDefinition_extendsImplementsSameType() {
         });
   }
 
-  @Test
-  void invalidClassDefinition_assignmentWithUnscopedVariableExprStatement() {
-    Variable variable = createVariable("x", TypeNode.INT);
-    VariableExpr variableExpr =
-        VariableExpr.builder().setVariable(variable).setIsDecl(true).build();
-
-    Variable anotherVariable = createVariable("y", TypeNode.INT);
-    Expr valueExpr = VariableExpr.builder().setVariable(anotherVariable).build();
-
-    AssignmentExpr assignmentExpr =
-        AssignmentExpr.builder().setVariableExpr(variableExpr).setValueExpr(valueExpr).build();
-
-    List<Statement> statements = Arrays.asList(ExprStatement.withExpr(assignmentExpr));
-    assertThrows(
-        IllegalStateException.class,
-        () -> {
-          ClassDefinition.builder()
-              .setPackageString("com.google.example.library.v1.stub")
-              .setName("LibraryServiceStub")
-              .setScope(ScopeNode.PUBLIC)
-              .setStatements(statements)
-              .build();
-        });
-  }
-
   @Test
   void invalidClassDefinition_unscopedVariableExprStatement() {
     List<Statement> statements =

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoVersion.golden

@@ -5,7 +5,7 @@ import com.google.api.core.InternalApi;
 @InternalApi("For internal use only")
 final class Version {
   // {x-version-update-start:gapic-showcase:current}
-  public static final String VERSION = "0.0.0-SNAPSHOT";
+  static final String VERSION = "0.0.0-SNAPSHOT";
   // {x-version-update-end}
 
 }

java-showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/Version.java

@@ -21,7 +21,7 @@
 @InternalApi("For internal use only")
 final class Version {
   // {x-version-update-start:gapic-showcase:current}
-  public static final String VERSION = "0.0.0-SNAPSHOT";
+  static final String VERSION = "0.0.0-SNAPSHOT";
   // {x-version-update-end}
 
 }

test/integration/goldens/apigeeconnect/src/com/google/cloud/apigeeconnect/v1/stub/Version.java

@@ -21,7 +21,7 @@
 @InternalApi("For internal use only")
 final class Version {
   // {x-version-update-start:null:current}
-  public static final String VERSION = "0.0.0-SNAPSHOT";
+  static final String VERSION = "0.0.0-SNAPSHOT";
   // {x-version-update-end}
 
 }

test/integration/goldens/asset/src/com/google/cloud/asset/v1/stub/Version.java

@@ -21,7 +21,7 @@
 @InternalApi("For internal use only")
 final class Version {
   // {x-version-update-start:null:current}
-  public static final String VERSION = "0.0.0-SNAPSHOT";
+  static final String VERSION = "0.0.0-SNAPSHOT";
   // {x-version-update-end}
 
 }

test/integration/goldens/bigtable/src/com/google/cloud/bigtable/data/v2/stub/Version.java

@@ -21,7 +21,7 @@
 @InternalApi("For internal use only")
 final class Version {
   // {x-version-update-start:null:current}
-  public static final String VERSION = "0.0.0-SNAPSHOT";
+  static final String VERSION = "0.0.0-SNAPSHOT";
   // {x-version-update-end}
 
 }

test/integration/goldens/compute/src/com/google/cloud/compute/v1small/stub/Version.java

@@ -21,7 +21,7 @@
 @InternalApi("For internal use only")
 final class Version {
   // {x-version-update-start:null:current}
-  public static final String VERSION = "0.0.0-SNAPSHOT";
+  static final String VERSION = "0.0.0-SNAPSHOT";
   // {x-version-update-end}
 
 }

test/integration/goldens/credentials/src/com/google/cloud/iam/credentials/v1/stub/Version.java

@@ -21,7 +21,7 @@
 @InternalApi("For internal use only")
 final class Version {
   // {x-version-update-start:null:current}
-  public static final String VERSION = "0.0.0-SNAPSHOT";
+  static final String VERSION = "0.0.0-SNAPSHOT";
   // {x-version-update-end}
 
 }