Skip to content

Commit a5866c6

Browse files
committed
fix: use builder in tests
1 parent 69a1c6c commit a5866c6

8 files changed

Lines changed: 14 additions & 21 deletions

File tree

gax-java/gax/src/main/java/com/google/api/gax/rpc/LibraryMetadata.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public abstract class LibraryMetadata {
5151
@Nullable
5252
public abstract String artifactName();
5353

54-
public static LibraryMetadata.Builder builder() {
54+
public static LibraryMetadata.Builder newBuilder() {
5555
return new AutoValue_LibraryMetadata.Builder();
5656
}
5757

gax-java/gax/src/test/java/com/google/api/gax/tracing/ApiTracerContextTest.java

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -38,30 +38,23 @@
3838
import org.junit.jupiter.api.Test;
3939

4040
class ApiTracerContextTest {
41-
private LibraryMetadata gapicProperties;
41+
private LibraryMetadata libraryMetadata;
4242

4343
@BeforeEach
4444
public void setUp() {
45-
gapicProperties =
46-
new LibraryMetadata() {
47-
@Override
48-
public String repository() {
49-
return "test-repo";
50-
}
51-
52-
@Override
53-
public String artifactName() {
54-
return "test-artifact";
55-
}
56-
};
45+
libraryMetadata =
46+
LibraryMetadata.newBuilder()
47+
.setArtifactName("test-artifact")
48+
.setRepository("test-repo")
49+
.build();
5750
}
5851

5952
@Test
6053
void testGetAttemptAttributes() {
6154
ApiTracerContext context =
6255
ApiTracerContext.newBuilder()
6356
.setServerAddress("test-address")
64-
.setLibraryMetadata(gapicProperties)
57+
.setLibraryMetadata(libraryMetadata)
6558
.build();
6659
Map<String, String> attributes = context.getAttemptAttributes();
6760

java-showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/ComplianceStubSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ protected ComplianceStubSettings(Builder settingsBuilder) throws IOException {
395395

396396
@Override
397397
protected LibraryMetadata getLibraryMetadata() {
398-
return LibraryMetadata.builder()
398+
return LibraryMetadata.newBuilder()
399399
.setArtifactName("com.google.cloud:gapic-showcase")
400400
.setRepository("googleapis/sdk-platform-java")
401401
.build();

java-showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/EchoStubSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ protected EchoStubSettings(Builder settingsBuilder) throws IOException {
584584

585585
@Override
586586
protected LibraryMetadata getLibraryMetadata() {
587-
return LibraryMetadata.builder()
587+
return LibraryMetadata.newBuilder()
588588
.setArtifactName("com.google.cloud:gapic-showcase")
589589
.setRepository("googleapis/sdk-platform-java")
590590
.build();

java-showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/IdentityStubSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ protected IdentityStubSettings(Builder settingsBuilder) throws IOException {
415415

416416
@Override
417417
protected LibraryMetadata getLibraryMetadata() {
418-
return LibraryMetadata.builder()
418+
return LibraryMetadata.newBuilder()
419419
.setArtifactName("com.google.cloud:gapic-showcase")
420420
.setRepository("googleapis/sdk-platform-java")
421421
.build();

java-showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/MessagingStubSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ protected MessagingStubSettings(Builder settingsBuilder) throws IOException {
590590

591591
@Override
592592
protected LibraryMetadata getLibraryMetadata() {
593-
return LibraryMetadata.builder()
593+
return LibraryMetadata.newBuilder()
594594
.setArtifactName("com.google.cloud:gapic-showcase")
595595
.setRepository("googleapis/sdk-platform-java")
596596
.build();

java-showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/SequenceServiceStubSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ protected SequenceServiceStubSettings(Builder settingsBuilder) throws IOExceptio
386386

387387
@Override
388388
protected LibraryMetadata getLibraryMetadata() {
389-
return LibraryMetadata.builder()
389+
return LibraryMetadata.newBuilder()
390390
.setArtifactName("com.google.cloud:gapic-showcase")
391391
.setRepository("googleapis/sdk-platform-java")
392392
.build();

java-showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/TestingStubSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ protected TestingStubSettings(Builder settingsBuilder) throws IOException {
498498

499499
@Override
500500
protected LibraryMetadata getLibraryMetadata() {
501-
return LibraryMetadata.builder()
501+
return LibraryMetadata.newBuilder()
502502
.setArtifactName("com.google.cloud:gapic-showcase")
503503
.setRepository("googleapis/sdk-platform-java")
504504
.build();

0 commit comments

Comments
 (0)