tests: Update per AI feedback.

Author: blakeli0

java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITProtobuf3Compatibility.java

@@ -1,7 +1,5 @@
 package com.google.showcase.v1beta1.it;
 
-import static com.google.common.truth.Truth.assertThat;
-
 import org.junit.jupiter.api.Test;
 import org.tensorflow.Graph;
 import org.tensorflow.Session;
@@ -11,39 +9,58 @@
 import org.tensorflow.proto.GraphDef;
 import org.tensorflow.types.TInt32;
 
-// Tensorflow depends on protobuf 3.x gen code and runtime, we test it in showcase module to prove
-// that it works with
-// protobuf 4.33+ gen code and runtime that comes with client libraries.
+import static com.google.common.truth.Truth.assertThat;
+
+/**
+ * Tensorflow depends on protobuf 3.x gen code and runtime, we test it in showcase module to prove that it works with
+ * protobuf 4.33+ gen code and runtime that comes with client libraries.
+ */
 public class ITProtobuf3Compatibility {
 
-  @Test
-  void testTensorflow_helloWorldExample() {
-    try (Graph graph = new Graph()) {
-      // Hello world example for "10 + 32" operation.
-      Ops tf = Ops.create(graph);
+    @Test
+    void testTensorflow_helloWorldExample() {
+        try (Graph graph = new Graph()) {
+            // Hello world example for "10 + 32" operation.
+            Ops tf = Ops.create(graph);
 
-      Constant<TInt32> expectedValue1 = tf.constant(10);
-      Constant<TInt32> expectedValue2 = tf.constant(32);
+            int expectedValue1 = 10;
+            int expectedValue2 = 32;
+            int expectedSum = 42;
 
-      Add<TInt32> sum = tf.math.add(expectedValue1, expectedValue2);
+            String name1 = "constant1";
+            String name2 = "constant2";
 
-      try (Session s = new Session(graph)) {
-        try (TInt32 result = (TInt32) s.runner().fetch(sum).run().get(0)) {
-          System.out.println("10 + 32 = " + result.getInt());
-        }
-      }
+            Constant<TInt32> constant1 = tf.withName(name1).constant(expectedValue1);
+            Constant<TInt32> constant2 = tf.withName(name2).constant(expectedValue2);
 
-      // GraphDef is a protobuf gen code.
-      GraphDef graphDef = graph.toGraphDef();
+            Add<TInt32> sum = tf.math.add(constant1, constant2);
 
-      // Inspect the protobuf gen code
-      Integer actual1 =
-          graphDef.getNode(0).getAttrOrThrow("value").getTensor().getIntValList().get(0);
-      Integer actual2 =
-          graphDef.getNode(1).getAttrOrThrow("value").getTensor().getIntValList().get(0);
+            try (Session s = new Session(graph)) {
+                try (TInt32 result = (TInt32) s.runner().fetch(sum).run().get(0)) {
+                    int actualResult = result.getInt();
+                    assertThat(actualResult).isEqualTo(expectedSum);
+                }
+            }
+
+            //GraphDef is a protobuf gen code.
+            GraphDef graphDef = graph.toGraphDef();
+
+            //Inspect the protobuf gen code
+            Integer actual1 = getValueFromGraphDefByName(graphDef, name1);
+            Integer actual2 = getValueFromGraphDefByName(graphDef, name2);
+
+            assertThat(actual1).isEqualTo(expectedValue1);
+            assertThat(actual2).isEqualTo(expectedValue2);
+        }
+    }
 
-      assertThat(actual1).isEqualTo(expectedValue1);
-      assertThat(actual2).isEqualTo(expectedValue2);
+    private static Integer getValueFromGraphDefByName(GraphDef graphDef, String name1) {
+        return graphDef.getNodeList()
+                .stream()
+                .filter(nodeDef -> nodeDef.getName().equals(name1))
+                .findFirst()
+                .get()
+                .getAttrOrThrow("value")
+                .getTensor().getIntValList().get(0);
     }
-  }
 }