Skip to content

Commit c029d4f

Browse files
committed
update showcase tests
1 parent dc73a51 commit c029d4f

2 files changed

Lines changed: 17 additions & 25 deletions

File tree

java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/logging/ITLogging1x.java

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,15 @@
2121
import ch.qos.logback.classic.Level;
2222
import ch.qos.logback.classic.spi.ILoggingEvent;
2323
import com.fasterxml.jackson.databind.JsonNode;
24+
import com.fasterxml.jackson.databind.ObjectMapper;
2425
import com.google.api.gax.grpc.GrpcLoggingInterceptor;
2526
import com.google.api.gax.httpjson.HttpJsonLoggingInterceptor;
2627
import com.google.common.collect.ImmutableMap;
2728
import com.google.showcase.v1beta1.EchoClient;
2829
import com.google.showcase.v1beta1.EchoRequest;
2930
import com.google.showcase.v1beta1.EchoResponse;
3031
import com.google.showcase.v1beta1.it.util.TestClientInitializer;
32+
import java.io.IOException;
3133
import java.util.List;
3234
import java.util.Map;
3335
import java.util.concurrent.TimeUnit;
@@ -51,6 +53,7 @@ public class ITLogging1x {
5153
private static final String ENDPOINT = "http://localhost:7469";
5254
private static final String SENDING_REQUEST_MESSAGE = "Sending request";
5355
private static final String RECEIVING_RESPONSE_MESSAGE = "Received response";
56+
private final ObjectMapper objectMapper = new ObjectMapper();
5457

5558
private static Logger logger = LoggerFactory.getLogger(ITLogging1x.class);
5659

@@ -133,16 +136,17 @@ void testGrpc_receiveContent_logDebug() {
133136
}
134137

135138
@Test
136-
void testGrpc_receiveContent_logDebug_structured_log() {
139+
void testGrpc_receiveContent_logDebug_structured_log() throws IOException {
137140
TestMdcAppender testAppender = setupTestMdcAppender(GrpcLoggingInterceptor.class, Level.DEBUG);
138141
assertThat(echoGrpc(ECHO_STRING)).isEqualTo(ECHO_STRING);
139-
List<JsonNode> jsonNodes = testAppender.getLoggingEntries();
140-
assertThat(jsonNodes.size()).isEqualTo(2);
141-
System.out.println(jsonNodes.get(1));
142-
assertThat(jsonNodes.get(0).get("message").asText()).isEqualTo("Sending request");
143-
assertThat(jsonNodes.get(0).get("request.payload").get("content").asText()).isEqualTo("echo?");
144-
assertThat(jsonNodes.get(1).get("message").asText()).isEqualTo("Received response");
145-
assertThat(jsonNodes.get(1).get("response.payload").get("content").asText()).isEqualTo("echo?");
142+
List<byte[]> byteLists = testAppender.getByteLists();
143+
assertThat(byteLists.size()).isEqualTo(2);
144+
JsonNode request = objectMapper.readTree(byteLists.get(0));
145+
assertThat(request.get("message").asText()).isEqualTo("Sending request");
146+
assertThat(request.get("request.payload").get("content").asText()).isEqualTo("echo?");
147+
JsonNode response = objectMapper.readTree(byteLists.get(1));
148+
assertThat(response.get("message").asText()).isEqualTo("Received response");
149+
assertThat(response.get("response.payload").get("content").asText()).isEqualTo("echo?");
146150

147151
testAppender.stop();
148152
}

java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/logging/TestMdcAppender.java

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@
22

33
import ch.qos.logback.classic.spi.ILoggingEvent;
44
import ch.qos.logback.core.AppenderBase;
5-
import com.fasterxml.jackson.databind.JsonNode;
6-
import com.fasterxml.jackson.databind.ObjectMapper;
75
import com.google.api.logging.SDKLoggingMdcJsonProvider;
8-
import java.io.IOException;
96
import java.util.ArrayList;
107
import java.util.Collections;
118
import java.util.List;
@@ -14,16 +11,12 @@
1411
public class TestMdcAppender extends AppenderBase<ILoggingEvent> {
1512

1613
private final LogstashEncoder encoder;
17-
18-
private final ObjectMapper objectMapper;
19-
20-
private final List<JsonNode> jsonNodes;
14+
private final List<byte[]> byteLists;
2115

2216
public TestMdcAppender() {
2317
encoder = new LogstashEncoder();
2418
encoder.addProvider(new SDKLoggingMdcJsonProvider());
25-
objectMapper = new ObjectMapper();
26-
jsonNodes = new ArrayList<>();
19+
byteLists = new ArrayList<>();
2720
}
2821

2922
@Override
@@ -40,15 +33,10 @@ public void stop() {
4033

4134
@Override
4235
protected void append(ILoggingEvent eventObject) {
43-
byte[] encodedBytes = encoder.encode(eventObject);
44-
try {
45-
jsonNodes.add(objectMapper.readTree(encodedBytes));
46-
} catch (IOException e) {
47-
throw new RuntimeException(e);
48-
}
36+
byteLists.add(encoder.encode(eventObject));
4937
}
5038

51-
public List<JsonNode> getLoggingEntries() {
52-
return Collections.unmodifiableList(jsonNodes);
39+
public List<byte[]> getByteLists() {
40+
return Collections.unmodifiableList(byteLists);
5341
}
5442
}

0 commit comments

Comments
 (0)