fix: handle request body and unknown error

Author: diegomarquezp

gax-java/gax/src/main/java/com/google/api/gax/tracing/ErrorTypeUtil.java

@@ -88,8 +88,6 @@ public String toString() {
    *         <li>{@code CLIENT_REDIRECT_ERROR}: Problem handling HTTP redirects.
    *         <li>{@code CLIENT_AUTHENTICATION_ERROR}: Error during credential acquisition or
    *             application.
-   *         <li>{@code CLIENT_UNKNOWN_ERROR}: Other unclassified client-side network or protocol
-   *             errors.
    *       </ul>
    *   <li><b>Language-specific error type:</b> The class or struct name of the exception or error
    *       if available. This must be low-cardinality, meaning it returns the short name of the
@@ -174,13 +172,12 @@ private static String getClientSideError(Throwable error) {
     if (error instanceof IllegalArgumentException) { // This covers CLIENT_REQUEST_ERROR
       return ErrorType.CLIENT_REQUEST_ERROR.toString();
     }
-    if (error.getClass().getSimpleName().contains("RequestBodyException")) {
+    if (isRequestBodyError(error)) {
       return ErrorType.CLIENT_REQUEST_BODY_ERROR.toString();
     }
-    if (error.getClass().getSimpleName().contains("UnknownClientException")) {
+    if (isClientUnknownError(error)) {
       return ErrorType.CLIENT_UNKNOWN_ERROR.toString();
     }
-
     return null;
   }
 
@@ -208,4 +205,12 @@ private static boolean isClientRedirectError(Throwable e) {
   private static boolean isClientAuthenticationError(Throwable e) {
     return e.getClass().getName().contains("GoogleAuthException");
   }
+
+  private static boolean isRequestBodyError(Throwable e) {
+    return e.getClass().getName().contains("RestSerializationException");
+  }
+
+  private static boolean isClientUnknownError(Throwable e) {
+    return e.getClass().getName().toLowerCase().contains("unknown");
+  }
 }

gax-java/gax/src/test/java/com/google/api/gax/tracing/SpanTracerTest.java

@@ -261,7 +261,7 @@ void testAttemptFailed_clientRequestBodyError() {
 
     tracer.attemptStarted(new Object(), 1);
 
-    tracer.attemptFailedRetriesExhausted(new RequestBodyException());
+    tracer.attemptFailedRetriesExhausted(new TestRestSerializationException());
 
     verify(attemptHandle)
         .addAttribute(
@@ -338,7 +338,7 @@ public RedirectException(String message) {
     }
   }
 
-  private static class RequestBodyException extends RuntimeException {}
+  private static class TestRestSerializationException extends RuntimeException {}
 
   private static class UnknownClientException extends RuntimeException {}
 }