Updating style for Drive Activity v2 API sample.

Author: jsmeredith

drive/activity-v2/index.js

@@ -94,16 +94,16 @@ function listDriveActivity(auth) {
   const params = {
     'pageSize': 10,
   };
-  service.activity.query({requestBody:params}, (err, res) => {
+  service.activity.query({requestBody: params}, (err, res) => {
     if (err) return console.error('The API returned an error: ' + err);
     const activities = res.data.activities;
     if (activities) {
       console.log('Recent activity:');
       activities.forEach((activity) => {
-        var time = getTimeInfo(activity);
-        var action = getActionInfo(activity['primaryActionDetail']);
-        var actors = activity.actors.map(getActorInfo);
-        var targets = activity.targets.map(getTargetInfo);
+        const time = getTimeInfo(activity);
+        const action = getActionInfo(activity['primaryActionDetail']);
+        const actors = activity.actors.map(getActorInfo);
+        const targets = activity.targets.map(getTargetInfo);
         console.log(`${time}: ${truncated(actors)}, ${action}, ` +
                             `${truncated(targets)}`);
       });
@@ -113,22 +113,40 @@ function listDriveActivity(auth) {
   });
 }
 
-/** Returns a string representation of the first elements in a list. */
+/**
+ * Returns a string representation of the first elements in a list.
+ *
+ * @param {Array<Object>} array The array to convert to a short string.
+ * @param {number} limit The number of elements to show before truncating.
+ * @return {string}
+ */
 function truncated(array, limit = 2) {
-  var contents = array.slice(0, limit).join(', ');
-  var more = array.length > limit ? ', ...' : '';
+  const contents = array.slice(0, limit).join(', ');
+  const more = array.length > limit ? ', ...' : '';
   return `[${contents}${more}]`;
 }
 
-/** Returns the name of a set property in an object, or else "unknown". */
+/**
+ * Returns the name of a set property in an object, or else "unknown".
+ *
+ * @param {Object} object The object in which to find the set property.
+ * @return {string}
+ */
 function getOneOf(object) {
-  for (var key in object) {
-    return key;
+  for (const key in object) {
+    if (object.hasOwnProperty(key)) {
+      return key;
+    }
   }
   return 'unknown';
 }
 
-/** Returns a time associated with an activity. */
+/**
+ * Returns a time associated with an activity.
+ *
+ * @param {Object} activity The DriveActivity from which to extract a time.
+ * @return {string}
+ */
 function getTimeInfo(activity) {
   if ('timestamp' in activity) {
     return activity.timestamp;
@@ -139,42 +157,62 @@ function getTimeInfo(activity) {
   return 'unknown';
 }
 
-/** Returns the type of action. */
+/**
+ * Returns the type of action.
+ *
+ * @param {Object} actionDetail The ActionDetail to summarize.
+ * @return {string}
+ */
 function getActionInfo(actionDetail) {
   return getOneOf(actionDetail);
 }
 
-/** Returns user information, or the type of user if not a known user. */
+/**
+ * Returns user information, or the type of user if not a known user.
+ *
+ * @param {Object} user The User to summarize.
+ * @return {string}
+ */
 function getUserInfo(user) {
   if ('knownUser' in user) {
-    var knownUser = user['knownUser'];
-    var isMe = knownUser['isCurrentUser'] || false;
+    const knownUser = user['knownUser'];
+    const isMe = knownUser['isCurrentUser'] || false;
     return isMe ? 'people/me' : knownUser['personName'];
   }
   return getOneOf(user);
 }
 
-/** Returns actor information, or the type of actor if not a user. */
+/**
+ * Returns actor information, or the type of actor if not a user.
+ *
+ * @param {Object} actor The Actor to summarize.
+ * @return {string}
+ */
 function getActorInfo(actor) {
   if ('user' in actor) {
-    return getUserInfo(actor['user'])
+    return getUserInfo(actor['user']);
   }
   return getOneOf(actor);
 }
 
-/** Returns the type of a target and an associated title. */
+/**
+ * Returns the type of a target and an associated title.
+ *
+ * @param {Object} target The Target to summarize.
+ * @return {string}
+ */
 function getTargetInfo(target) {
   if ('driveItem' in target) {
-    var title = target.driveItem.title || 'unknown';
+    const title = target.driveItem.title || 'unknown';
     return `driveItem:"${title}"`;
   }
   if ('teamDrive' in target) {
-    var title = target.teamDrive.title || 'unknown';
+    const title = target.teamDrive.title || 'unknown';
     return `teamDrive:"${title}"`;
   }
   if ('fileComment' in target) {
-    var parent = target.fileComment.parent || {};
-    var title = parent.title || 'unknown';
+    const parent = target.fileComment.parent || {};
+    const title = parent.title || 'unknown';
     return `fileComment:"${title}"`;
   }
   return `${getOneOf(target)}:unknown`;