exit loops early where possible

Author: loganmc10

internal/gameServer/server.go

@@ -186,8 +186,10 @@ func (g *GameServer) ManagePlayers() {
 						if v.(Client).Number == int(i) {
 							g.Players.Delete(k)
 							g.NeedsUpdatePlayers.Store(true)
+							return false
+						} else {
+							return true
 						}
-						return true
 					})
 					g.gameData.bufferHealth[i] = g.gameData.bufferHealth[i][:0]
 				}
@@ -211,8 +213,10 @@ func (g *GameServer) IsRoomCreator(socket *websocket.Conn) bool {
 	g.Players.Range(func(k, v any) bool {
 		if v.(*Client).Number == 0 && v.(*Client).Socket == socket {
 			roomCreator = true
+			return false
+		} else {
+			return true
 		}
-		return true
 	})
 	return roomCreator
 }

internal/gameServer/tcp.go

@@ -346,8 +346,10 @@ func (g *GameServer) processTCP(conn *net.TCPConn) {
 						if v.(Client).Number == int(i) {
 							g.Players.Delete(k)
 							g.NeedsUpdatePlayers.Store(true)
+							return false
+						} else {
+							return true
 						}
-						return true
 					})
 
 					g.gameData.bufferHealth[i] = g.gameData.bufferHealth[i][:0]
@@ -410,8 +412,11 @@ func (g *GameServer) watchTCP() {
 			g.Players.Range(func(k, v any) bool {
 				if remoteAddr.IP.Equal(v.(Client).IP) {
 					validated = true
+					return false
+				} else {
+					return true
 				}
-				return true
+
 			})
 			if !validated {
 				g.Logger.Error(fmt.Errorf("invalid tcp connection"), "bad IP", "IP", conn.RemoteAddr().String())

internal/gameServer/udp.go

@@ -185,8 +185,10 @@ func (g *GameServer) watchUDP() {
 			g.Players.Range(func(k, v any) bool {
 				if addr.IP.Equal(v.(Client).IP) {
 					validated = true
+					return false
+				} else {
+					return true
 				}
-				return true
 			})
 			if !validated {
 				g.Logger.Error(fmt.Errorf("invalid udp connection"), "bad IP", "IP", addr.IP)

internal/lobbyServer/lobby.go

@@ -310,8 +310,10 @@ func (s *LobbyServer) wsHandler(w http.ResponseWriter, r *http.Request) {
 							w.(*gameserver.Client).InLobby = false
 						}
 						s.updatePlayers(v)
+						return false
+					} else {
+						return true
 					}
-					return true
 				})
 				if !v.Running {
 					if v.GetPlayersLength() == 0 {
@@ -505,8 +507,10 @@ func (s *LobbyServer) wsHandler(w http.ResponseWriter, r *http.Request) {
 				g.Players.Range(func(k, i any) bool {
 					if receivedMessage.PlayerName == k {
 						duplicateName = true
+						return false
+					} else {
+						return true
 					}
-					return true
 				})
 				if g.Password != "" && g.Password != receivedMessage.Room.Password {
 					accepted = BadPassword
@@ -537,8 +541,10 @@ func (s *LobbyServer) wsHandler(w http.ResponseWriter, r *http.Request) {
 						g.Players.Range(func(k, v any) bool {
 							if v.(*gameserver.Client).Number == number {
 								goodNumber = false
+								return false
+							} else {
+								return true
 							}
-							return true
 						})
 						if goodNumber {
 							break
@@ -634,8 +640,10 @@ func (s *LobbyServer) wsHandler(w http.ResponseWriter, r *http.Request) {
 						g.Players.Range(func(k, v any) bool {
 							if !v.(*gameserver.Client).IP.IsPrivate() {
 								privateNetwork = false
+								return false
+							} else {
+								return true
 							}
-							return true
 						})
 						if privateNetwork {
 							g.BufferTarget = 1