-
Notifications
You must be signed in to change notification settings - Fork 7
Expand file tree
/
Copy pathpage_test.go
More file actions
262 lines (222 loc) · 7.85 KB
/
page_test.go
File metadata and controls
262 lines (222 loc) · 7.85 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
package pgkit_test
import (
"strings"
"testing"
sq "github.com/Masterminds/squirrel"
"github.com/goware/pgkit/v2"
"github.com/stretchr/testify/require"
)
type T struct{}
func TestPagination(t *testing.T) {
const (
DefaultSize = 2
MaxSize = 5
Sort = "ID"
)
paginator := pgkit.NewPaginator[T](
pgkit.WithColumnFunc(strings.ToLower),
pgkit.WithDefaultSize(DefaultSize),
pgkit.WithMaxSize(MaxSize),
pgkit.WithSort(Sort),
)
page := pgkit.NewPage(0, 0)
result, query := paginator.PrepareQuery(sq.Select("*").From("t"), page)
require.Len(t, result, 0)
require.Equal(t, &pgkit.Page{Page: 1, Size: DefaultSize}, page)
sql, args, err := query.ToSql()
require.NoError(t, err)
require.Equal(t, `SELECT * FROM t ORDER BY "id" ASC LIMIT 3 OFFSET 0`, sql)
require.Empty(t, args)
// Verify page.Column and page.Sort are not modified
require.Empty(t, page.Column)
require.Len(t, page.Sort, 0)
result = paginator.PrepareResult(make([]T, 0), page)
require.Len(t, result, 0)
require.Equal(t, &pgkit.Page{Page: 1, Size: DefaultSize}, page)
result = paginator.PrepareResult(make([]T, DefaultSize), page)
require.Len(t, result, DefaultSize)
require.Equal(t, &pgkit.Page{Page: 1, Size: DefaultSize}, page)
result = paginator.PrepareResult(make([]T, DefaultSize+2), page)
require.Len(t, result, DefaultSize)
require.Equal(t, &pgkit.Page{Page: 1, Size: DefaultSize, More: true}, page)
}
func TestInvalidSort(t *testing.T) {
paginator := pgkit.NewPaginator[T]()
page := pgkit.NewPage(0, 0)
page.Sort = []pgkit.Sort{
{Column: "ID; DROP TABLE users;", Order: pgkit.Asc},
{Column: "name", Order: pgkit.Desc},
}
_, query := paginator.PrepareQuery(sq.Select("*").From("t"), page)
sql, args, err := query.ToSql()
require.NoError(t, err)
require.Equal(t, "SELECT * FROM t ORDER BY \"ID; DROP TABLE users;\" ASC, \"name\" DESC LIMIT 11 OFFSET 0", sql)
require.Empty(t, args)
// Verify columns in page.Sort are not quoted
require.Equal(t, "ID; DROP TABLE users;", page.Sort[0].Column)
require.Equal(t, "name", page.Sort[1].Column)
}
func TestPageColumnInjection(t *testing.T) {
paginator := pgkit.NewPaginator[T]()
page := pgkit.NewPage(0, 0)
page.Column = "id; DROP TABLE users;--"
_, query := paginator.PrepareQuery(sq.Select("*").From("t"), page)
sql, args, err := query.ToSql()
require.NoError(t, err)
require.Equal(t, "SELECT * FROM t ORDER BY \"id; DROP TABLE users;--\" ASC LIMIT 11 OFFSET 0", sql)
require.Empty(t, args)
// Verify column in page is not quoted
require.Equal(t, "id; DROP TABLE users;--", page.Column)
}
func TestPageColumnSpaces(t *testing.T) {
paginator := pgkit.NewPaginator[T]()
page := pgkit.NewPage(0, 0)
page.Column = "id, name"
_, query := paginator.PrepareQuery(sq.Select("*").From("t"), page)
sql, args, err := query.ToSql()
require.NoError(t, err)
require.Equal(t, "SELECT * FROM t ORDER BY \"id\" ASC, \"name\" ASC LIMIT 11 OFFSET 0", sql)
require.Empty(t, args)
// Verify column in page is not quoted
require.Equal(t, "id, name", page.Column)
}
func TestSortOrderInjection(t *testing.T) {
paginator := pgkit.NewPaginator[T]()
page := pgkit.NewPage(0, 0)
page.Sort = []pgkit.Sort{
{Column: "id", Order: pgkit.Order("DESC; DROP TABLE users;--")},
{Column: "name", Order: pgkit.Order("desc")},
{Column: "created_at", Order: pgkit.Order(" ASC ")},
}
_, query := paginator.PrepareQuery(sq.Select("*").From("t"), page)
sql, args, err := query.ToSql()
require.NoError(t, err)
require.Equal(t, "SELECT * FROM t ORDER BY \"id\" ASC, \"name\" DESC, \"created_at\" ASC LIMIT 11 OFFSET 0", sql)
require.Empty(t, args)
// Verify columns in page.Sort are not quoted
require.Equal(t, "id", page.Sort[0].Column)
require.Equal(t, "name", page.Sort[1].Column)
require.Equal(t, "created_at", page.Sort[2].Column)
}
func TestPaginationEdgeCases(t *testing.T) {
// Test case 1: nil options, NewPage with zeros
paginator1 := pgkit.NewPaginator[T]()
page1 := pgkit.NewPage(0, 0)
result1, query1 := paginator1.PrepareQuery(sq.Select("*").From("t"), page1)
require.Len(t, result1, 0)
require.Equal(t, &pgkit.Page{Page: 1, Size: 10}, page1)
sql1, _, err1 := query1.ToSql()
require.NoError(t, err1)
require.Equal(t, "SELECT * FROM t LIMIT 11 OFFSET 0", sql1)
// Test case 2: nil options, empty struct assignment
paginator2 := pgkit.NewPaginator[T]()
page2 := &pgkit.Page{}
result2, query2 := paginator2.PrepareQuery(sq.Select("*").From("t"), page2)
require.Len(t, result2, 0)
require.Equal(t, &pgkit.Page{Page: 1, Size: 10}, page2)
sql2, _, err2 := query2.ToSql()
require.NoError(t, err2)
require.Equal(t, "SELECT * FROM t LIMIT 11 OFFSET 0", sql2)
// Test case 3: empty options, NewPage
paginator3 := pgkit.NewPaginator[T]()
page3 := pgkit.NewPage(0, 0)
result3, query3 := paginator3.PrepareQuery(sq.Select("*").From("t"), page3)
require.Len(t, result3, 0)
require.Equal(t, &pgkit.Page{Page: 1, Size: 10}, page3)
sql3, _, err3 := query3.ToSql()
require.NoError(t, err3)
require.Equal(t, "SELECT * FROM t LIMIT 11 OFFSET 0", sql3)
// Test case 4: max size lower than default size
paginator4 := pgkit.NewPaginator[T](pgkit.WithDefaultSize(20), pgkit.WithMaxSize(5))
page4 := &pgkit.Page{}
result4, query4 := paginator4.PrepareQuery(sq.Select("*").From("t"), page4)
require.Len(t, result4, 0)
require.Equal(t, &pgkit.Page{Page: 1, Size: 20}, page4)
sql4, _, err4 := query4.ToSql()
require.NoError(t, err4)
require.Equal(t, "SELECT * FROM t LIMIT 21 OFFSET 0", sql4)
}
func TestColumnFunc(t *testing.T) {
fn := func(column string) string {
switch column {
case "id":
return "ID"
case "name":
return "NAME"
default:
return column
}
}
paginator := pgkit.NewPaginator[T](
pgkit.WithColumnFunc(fn),
)
page := &pgkit.Page{
Page: 1,
Size: 10,
Sort: []pgkit.Sort{
{Column: "id", Order: pgkit.Asc},
{Column: "name", Order: pgkit.Desc},
{Column: "created_at", Order: pgkit.Asc},
},
}
_, query := paginator.PrepareQuery(sq.Select("*").From("t"), page)
sql, args, err := query.ToSql()
require.NoError(t, err)
require.Equal(t, `SELECT * FROM t ORDER BY "ID" ASC, "NAME" DESC, "created_at" ASC LIMIT 11 OFFSET 0`, sql)
require.Empty(t, args)
// Verify columns in page.Sort are not quoted
require.Equal(t, "id", page.Sort[0].Column)
require.Equal(t, "name", page.Sort[1].Column)
require.Equal(t, "created_at", page.Sort[2].Column)
}
func TestColumnFallbackUsesColumnFunc(t *testing.T) {
paginator := pgkit.NewPaginator[T](
pgkit.WithColumnFunc(strings.ToUpper),
pgkit.WithSort("id"),
)
page := &pgkit.Page{
Page: 1,
Size: 10,
Column: "name",
}
_, query := paginator.PrepareQuery(sq.Select("*").From("t"), page)
sql, args, err := query.ToSql()
require.NoError(t, err)
require.Equal(t, `SELECT * FROM t ORDER BY "NAME" ASC LIMIT 11 OFFSET 0`, sql)
require.Empty(t, args)
// Verify column in page is not quoted or transformed
require.Equal(t, "name", page.Column)
}
func TestSortTakesPrecedenceOverColumn(t *testing.T) {
paginator := pgkit.NewPaginator[T]()
page := &pgkit.Page{
Page: 1,
Size: 10,
Column: "name",
Sort: []pgkit.Sort{
{Column: "id", Order: pgkit.Desc},
},
}
_, query := paginator.PrepareQuery(sq.Select("*").From("t"), page)
sql, args, err := query.ToSql()
require.NoError(t, err)
require.Equal(t, `SELECT * FROM t ORDER BY "id" DESC LIMIT 11 OFFSET 0`, sql)
require.Empty(t, args)
// Verify sort column in page is not quoted
require.Equal(t, "id", page.Sort[0].Column)
}
func TestPaginationOffsetAndPageRecompute(t *testing.T) {
paginator := pgkit.NewPaginator[T]()
page := &pgkit.Page{
Page: 3,
Size: 2,
}
_, query := paginator.PrepareQuery(sq.Select("*").From("t"), page)
sql, args, err := query.ToSql()
require.NoError(t, err)
require.Equal(t, "SELECT * FROM t LIMIT 3 OFFSET 4", sql)
require.Empty(t, args)
result := paginator.PrepareResult(make([]T, 3), page)
require.Len(t, result, 2)
require.Equal(t, &pgkit.Page{Page: 3, Size: 2, More: true}, page)
}