Using readonly public poperties instead of private properties with setters

Author: peldax

composer.json

@@ -12,7 +12,7 @@
     }
   ],
   "require": {
-    "php": ">=8.1",
+    "php": ">=8.2",
     "infinityloop-dev/graphpinator-tokenizer": "^1.3",
     "infinityloop-dev/graphpinator-common": "^2.0",
     "infinityloop-dev/utils": "^2.0"

src/Directive/Directive.php

@@ -6,22 +6,12 @@
 
 use Graphpinator\Parser\Value\ArgumentValueSet;
 
-final class Directive
+final readonly class Directive
 {
     public function __construct(
-        private string $name,
-        private ?ArgumentValueSet $arguments,
+        public string $name,
+        public ?ArgumentValueSet $arguments,
     )
     {
     }
-
-    public function getName() : string
-    {
-        return $this->name;
-    }
-
-    public function getArguments() : ?ArgumentValueSet
-    {
-        return $this->arguments;
-    }
 }

src/Field/Field.php

@@ -7,40 +7,15 @@
 use Graphpinator\Parser\Directive\DirectiveSet;
 use Graphpinator\Parser\Value\ArgumentValueSet;
 
-final class Field
+final readonly class Field
 {
     public function __construct(
-        private string $name,
-        private ?string $alias = null,
-        private ?FieldSet $children = null,
-        private ?ArgumentValueSet $arguments = null,
-        private ?DirectiveSet $directives = null,
+        public string $name,
+        public ?string $alias = null,
+        public ?FieldSet $children = null,
+        public ?ArgumentValueSet $arguments = null,
+        public ?DirectiveSet $directives = null,
     )
     {
     }
-
-    public function getName() : string
-    {
-        return $this->name;
-    }
-
-    public function getAlias() : ?string
-    {
-        return $this->alias;
-    }
-
-    public function getFields() : ?FieldSet
-    {
-        return $this->children;
-    }
-
-    public function getArguments() : ?ArgumentValueSet
-    {
-        return $this->arguments;
-    }
-
-    public function getDirectives() : ?DirectiveSet
-    {
-        return $this->directives;
-    }
 }

src/Fragment/Fragment.php

@@ -8,34 +8,14 @@
 use Graphpinator\Parser\Field\FieldSet;
 use Graphpinator\Parser\TypeRef\NamedTypeRef;
 
-final class Fragment
+final readonly class Fragment
 {
     public function __construct(
-        private string $name,
-        private NamedTypeRef $typeCond,
-        private DirectiveSet $directives,
-        private FieldSet $fields,
+        public string $name,
+        public NamedTypeRef $typeCond,
+        public DirectiveSet $directives,
+        public FieldSet $fields,
     )
     {
     }
-
-    public function getName() : string
-    {
-        return $this->name;
-    }
-
-    public function getFields() : FieldSet
-    {
-        return $this->fields;
-    }
-
-    public function getTypeCond() : NamedTypeRef
-    {
-        return $this->typeCond;
-    }
-
-    public function getDirectives() : DirectiveSet
-    {
-        return $this->directives;
-    }
 }

src/Fragment/FragmentSet.php

@@ -17,6 +17,6 @@ final class FragmentSet extends ImplicitObjectMap
     #[\Override]
     protected function getKey(object $object) : string
     {
-        return $object->getName(); // @phpstan-ignore method.notFound
+        return $object->name; // @phpstan-ignore property.notFound
     }
 }

src/FragmentSpread/InlineFragmentSpread.php

@@ -8,32 +8,13 @@
 use Graphpinator\Parser\Field\FieldSet;
 use Graphpinator\Parser\TypeRef\NamedTypeRef;
 
-final class InlineFragmentSpread implements FragmentSpread
+final readonly class InlineFragmentSpread implements FragmentSpread
 {
-    private DirectiveSet $directives;
-
     public function __construct(
-        private FieldSet $fields,
-        ?DirectiveSet $directives = null,
-        private ?NamedTypeRef $typeCond = null,
+        public FieldSet $fields,
+        public DirectiveSet $directives = new DirectiveSet(),
+        public ?NamedTypeRef $typeCond = null,
     )
     {
-        $this->directives = $directives
-            ?? new DirectiveSet();
-    }
-
-    public function getFields() : FieldSet
-    {
-        return $this->fields;
-    }
-
-    public function getDirectives() : DirectiveSet
-    {
-        return $this->directives;
-    }
-
-    public function getTypeCond() : ?NamedTypeRef
-    {
-        return $this->typeCond;
     }
 }

src/FragmentSpread/NamedFragmentSpread.php

@@ -6,26 +6,16 @@
 
 use Graphpinator\Parser\Directive\DirectiveSet;
 
-final class NamedFragmentSpread implements FragmentSpread
+final readonly class NamedFragmentSpread implements FragmentSpread
 {
-    private DirectiveSet $directives;
+    public readonly DirectiveSet $directives;
 
     public function __construct(
-        private string $name,
+        public string $name,
         ?DirectiveSet $directives = null,
     )
     {
         $this->directives = $directives
             ?? new DirectiveSet();
     }
-
-    public function getName() : string
-    {
-        return $this->name;
-    }
-
-    public function getDirectives() : DirectiveSet
-    {
-        return $this->directives;
-    }
 }

src/Operation/Operation.php

@@ -9,47 +9,15 @@
 use Graphpinator\Parser\OperationType;
 use Graphpinator\Parser\Variable\VariableSet;
 
-final class Operation
+final readonly class Operation
 {
-    private VariableSet $variables;
-    private DirectiveSet $directives;
-
     public function __construct(
-        private OperationType $type,
-        private ?string $name,
-        ?VariableSet $variables,
-        ?DirectiveSet $directives,
-        private FieldSet $children,
+        public OperationType $type,
+        public FieldSet $children,
+        public ?string $name = null,
+        public VariableSet $variables = new VariableSet(),
+        public DirectiveSet $directives = new DirectiveSet(),
     )
     {
-        $this->variables = $variables
-            ?? new VariableSet();
-        $this->directives = $directives
-            ?? new DirectiveSet();
-    }
-
-    public function getType() : OperationType
-    {
-        return $this->type;
-    }
-
-    public function getName() : ?string
-    {
-        return $this->name;
-    }
-
-    public function getFields() : FieldSet
-    {
-        return $this->children;
-    }
-
-    public function getVariables() : VariableSet
-    {
-        return $this->variables;
-    }
-
-    public function getDirectives() : DirectiveSet
-    {
-        return $this->directives;
     }
 }

src/Operation/OperationSet.php

@@ -17,7 +17,7 @@ final class OperationSet extends ImplicitObjectMap
     #[\Override]
     protected function getKey(object $object) : string
     {
-        return $object->getName() // @phpstan-ignore method.notFound
+        return $object->name // @phpstan-ignore property.notFound
             ?? '';
     }
 }

src/ParsedRequest.php

@@ -7,22 +7,12 @@
 use Graphpinator\Parser\Fragment\FragmentSet;
 use Graphpinator\Parser\Operation\OperationSet;
 
-final class ParsedRequest
+final readonly class ParsedRequest
 {
     public function __construct(
-        private OperationSet $operations,
-        private FragmentSet $fragments,
+        public OperationSet $operations,
+        public FragmentSet $fragments,
     )
     {
     }
-
-    public function getOperations() : OperationSet
-    {
-        return $this->operations;
-    }
-
-    public function getFragments() : FragmentSet
-    {
-        return $this->fragments;
-    }
 }