feat: improve SimpleValidation, ConditionalValidationNotTriggered, CustomStrategy ~40%

Author: gravity-zero

src/DataVerify.php

@@ -61,13 +61,12 @@ class DataVerify
     private ValidationContext $context;
     private FieldCollection $fields;
     private ErrorCollection $errors;
-    private TranslationManager $translationManager;
+    private ?TranslationManager $translationManager = null;
     private bool $hasVerified = false;
 
     // Engines
     private ValidationOrchestrator $orchestrator;
     private ConditionalEngine $conditionalEngine;
-    private ErrorManager $errorManager;
     private DataTraverser $dataTraverser;
     private LazyValidationRegistry $lazyRegistry;
 
@@ -77,7 +76,6 @@ public function __construct(array|object $data)
         $this->context = new ValidationContext();
         $this->fields = new FieldCollection();
         $this->errors = new ErrorCollection();
-        $this->translationManager = new TranslationManager();
         $this->lazyRegistry = LazyValidationRegistry::instance();
 
         $this->initializeEngines();
@@ -87,12 +85,10 @@ private function initializeEngines(): void
     {
         $this->dataTraverser = new DataTraverser($this->data);
         $this->conditionalEngine = new ConditionalEngine($this->dataTraverser);
-        $this->errorManager = new ErrorManager($this->errors, $this->translationManager, $this->lazyRegistry);
 
         $this->orchestrator = new ValidationOrchestrator(
             $this->fields,
             $this->errors,
-            $this->errorManager,
             $this->dataTraverser,
             $this->conditionalEngine,
             new ValidationRegistry(),
@@ -261,27 +257,44 @@ public function alias(string $name): self
         return $this;
     }
 
+    /**
+     * Get or create translation manager lazily
+     */
+    private function getTranslationManager(): TranslationManager
+    {
+        if ($this->translationManager === null) {
+            $this->translationManager = new TranslationManager();
+        }
+        
+        // Injecter dans l'ErrorManager de l'Orchestrator (qui pourrait être lazy aussi)
+        // On crée l'ErrorManager maintenant si on configure les traductions
+        $errorManager = new ErrorManager($this->errors, $this->lazyRegistry, $this->translationManager);
+        $this->orchestrator->setErrorManager($errorManager);
+        
+        return $this->translationManager;
+    }
+
     public function setTranslator(TranslatorInterface $translator): self
     {
-        $this->translationManager->setTranslator($translator);
+        $this->getTranslationManager()->setTranslator($translator);
         return $this;
     }
 
     public function setLocale(string $locale): self
     {
-        $this->translationManager->setLocale($locale);
+        $this->getTranslationManager()->setLocale($locale);
         return $this;
     }
 
     public function addTranslations(array $translations, string $locale = 'en'): self
     {
-        $this->translationManager->addTranslations($translations, $locale);
+        $this->getTranslationManager()->addTranslations($translations, $locale);
         return $this;
     }
 
     public function loadLocale(string $locale, ?string $filePath = null): self
     {
-        $this->translationManager->loadLocale($locale, $filePath);
+        $this->getTranslationManager()->loadLocale($locale, $filePath);
         return $this;
     }
 
@@ -423,4 +436,4 @@ public static function enableIdeHelper(?string $outputPath = null): void
     {
         \Gravity\Documentation\IdeHelperManager::instance()->enable($outputPath);
     }
-}
+}

src/Engine/ErrorManager.php

@@ -15,11 +15,15 @@
  */
 class ErrorManager
 {
+    private ?TranslationManager $translationManager = null;
+    
     public function __construct(
         private ErrorCollection $errors,
-        private TranslationManager $translationManager,
-        private LazyValidationRegistry $registry
-    ) {}
+        private LazyValidationRegistry $registry,
+        ?TranslationManager $translationManager = null
+    ) {
+        $this->translationManager = $translationManager;
+    }
 
     /**
      * Add validation error with translated message
@@ -36,7 +40,7 @@ public function addError(
 
         if (!$errorMessage) {
             $params = $this->buildValidationParams($testName, $args);
-            $errorMessage = $this->translationManager->getValidationMessage(
+            $errorMessage = $this->getTranslationManager()->getValidationMessage(
                 $testName,
                 $alias,
                 $value,
@@ -93,9 +97,21 @@ private function mapArgsToParams(ValidationMetadata $metadata, array $args): arr
 
     /**
      * Get translation manager for external configuration
+     * Lazy-loads if not already set
      */
     public function getTranslationManager(): TranslationManager
     {
+        if ($this->translationManager === null) {
+            $this->translationManager = new TranslationManager();
+        }
         return $this->translationManager;
     }
+    
+    /**
+     * Set translation manager (for user customization)
+     */
+    public function setTranslationManager(TranslationManager $translationManager): void
+    {
+        $this->translationManager = $translationManager;
+    }
 }

src/Engine/ValidationOrchestrator.php

@@ -21,17 +21,37 @@
  */
 class ValidationOrchestrator
 {
+    private ?ErrorManager $errorManager = null;
+    
     public function __construct(
         private FieldCollection $fields,
         private ErrorCollection $errors,
-        private ErrorManager $errorManager,
         private DataTraverser $dataTraverser,
         private ConditionalEngine $conditionalEngine,
         private ValidationRegistry $registry,
         private LazyValidationRegistry $lazyRegistry
     ) {
         // No upfront initialization needed - lazy loading handles it
     }
+    
+    /**
+     * Get or create ErrorManager lazily (only when validation fails)
+     */
+    private function getErrorManager(): ErrorManager
+    {
+        if ($this->errorManager === null) {
+            $this->errorManager = new ErrorManager($this->errors, $this->lazyRegistry);
+        }
+        return $this->errorManager;
+    }
+    
+    /**
+     * Set ErrorManager (for external configuration like translations)
+     */
+    public function setErrorManager(ErrorManager $errorManager): void
+    {
+        $this->errorManager = $errorManager;
+    }
 
     /**
      * Execute all validations
@@ -135,7 +155,7 @@ private function executeValidation(
         if ($test === 'required' || !$this->dataTraverser->isValueEmpty($value)) {
             $result = $this->runValidationTest($test, $value, $args);
             if (!$result) {
-                $this->errorManager->addError($handler, $test, $value, $path, $args);
+                $this->getErrorManager()->addError($handler, $test, $value, $path, $args);
             }
         }
     }